Language Change PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
17 Nov 2025

Pull Request for Issue #46446

Summary of Changes

This PR sepaprates Legend of the fieldset and label of a field

Testing Instructions

I a frontend login form click the "forgot password" link.

Actual result BEFORE applying this Pull Request

The label of the fieldset is used for a legend. If there is no label, there would not be a legend at all, which is an a11y issue.
A legend is not an instruction but summarises the content of a fieldset.
This PR adds a legend for the fieldset, if there is a label or not.

grafik ### Expected result AFTER applying this Pull Request grafik

Note:
If this is accepted, same change is needed for similiar pages.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar chmst chmst - open - 17 Nov 2025
avatar chmst chmst - change - 17 Nov 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Nov 2025
Category Front End com_users Language & Strings
avatar chmst chmst - change - 17 Nov 2025
The description was changed
avatar chmst chmst - edited - 17 Nov 2025
avatar Kostelano
Kostelano - comment - 17 Nov 2025

The same issue is on the Login reminder page.
Can we fix this and do the same?

avatar brianteeman
brianteeman - comment - 17 Nov 2025

@Kostelano it already says that

avatar Kostelano
Kostelano - comment - 17 Nov 2025

@Kostelano it already says that

I didn't see it at first, now I see it

avatar ChristineWk ChristineWk - test_item - 17 Nov 2025 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 17 Nov 2025

I have tested this item ✅ successfully on 70e4a33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46451.

avatar richard67
richard67 - comment - 17 Nov 2025

@chmst If this PR is a bug fix, it should be made for 5.4-dev if it effects both 5.4 and 6.0, and it seems that's the case. And if it is a new feature it should be made for 6.1-dev. So I don't really understand why you have made it for 6.0-dev.

avatar chmst
chmst - comment - 17 Nov 2025

It is an enhancment.

avatar brianteeman
brianteeman - comment - 17 Nov 2025

it has to be made for 6.1 because there is a NEW language string (unfortunately)

avatar brianteeman
brianteeman - comment - 17 Nov 2025

But it could be made for 5.4 if you re-use the existing string COM_USERS_RESET which for me would be better as it really is a bug fix.

avatar chmst
chmst - comment - 17 Nov 2025

Thanks @brianteeman, will do this. I also see that the fieldset label is not necessary at all.

avatar chmst chmst - change - 17 Nov 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-11-17 15:17:54
Closed_By chmst
Labels Added: Language Change PR-6.0-dev
avatar chmst chmst - close - 17 Nov 2025
avatar chmst
chmst - comment - 17 Nov 2025

Closing for #46454

Add a Comment

Login with GitHub to post a comment