? Success
Not before # 5087

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
12 Oct 2014

Same as #4575 #4563 #4562 #4561 #4514 #4513

Testing:
After Applying this patch copy
Try the Template Manager

Follow the images to navigate:
screenshot 2014-10-12 23 29 30
screenshot 2014-10-12 23 29 44

And:
screenshot 2014-10-12 23 29 58
screenshot 2014-10-12 23 30 13

avatar dgt41 dgt41 - open - 12 Oct 2014
avatar jissues-bot jissues-bot - change - 12 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Oct 2014
Category Templates (admin) UI/UX
avatar dgt41 dgt41 - reference | - 14 Oct 14
avatar nicksavov nicksavov - change - 16 Oct 2014
The description was changed
Labels Added: ?
avatar zoom009
zoom009 - comment - 17 Oct 2014

@test

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4645.

avatar zoom009 zoom009 - test_item - 17 Oct 2014 - Tested successfully
avatar suredweb
suredweb - comment - 17 Oct 2014

@test It look good +1

avatar suredweb suredweb - test_item - 17 Oct 2014 - Tested successfully
avatar rajeshstarlite rajeshstarlite - test_item - 17 Oct 2014 - Tested successfully
avatar gunjanpatel gunjanpatel - change - 17 Oct 2014
Status Pending Ready to Commit
avatar gunjanpatel
gunjanpatel - comment - 17 Oct 2014

Moving to RTC as we have two successful tests.
Thanks @rajeshstarlite for reporting.

avatar Symatic
Symatic - comment - 17 Oct 2014

look good here

avatar brianteeman brianteeman - change - 17 Oct 2014
Status Ready to Commit Needs Review
avatar mtmeyrick mtmeyrick - test_item - 17 Oct 2014 - Tested successfully
avatar dgt41
dgt41 - comment - 5 Nov 2014

One short comment for PLT: @Bakual @betweenbrain @dbhurley @infograf768
This PR as well as the other ones dealing with the conversion of admin side modals to bootstrap [ #4661 #4575 #4563 ] were done primarily for isis but with very little effort (2 lines in less and some styling of a in an layout override) it WILL BE a very good fit for hathor as well. And here is the proof:
This PR with admin template hathor:
screen shot 2014-11-06 at 1 08 06
And here:
screen shot 2014-11-06 at 1 08 36

With only these additions to template.less:
screen shot 2014-11-06 at 1 09 07

So why do i write this?
If you decide that this is something that fits the project, and give me some reasonable deadline, I will provide all the needed code (which is not that much anyway) for Hathor compatibility.

avatar Bakual
Bakual - comment - 6 Nov 2014

@dgt41 Feel free to create a PR for that. We don't have deadlines. If it isn't ready for 3.4, then it can go fine into 3.5.

avatar infograf768
infograf768 - comment - 6 Nov 2014

PR has to be updated to current staging

avatar helvecio
helvecio - comment - 8 Nov 2014

@test Modal is responsive up to a certain point, then it dissappears. Tested locally on a desktop computer using FF. I think that the image should also be responsive, scaling down to still be visible.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4645.

avatar dgt41
dgt41 - comment - 28 Dec 2014

@helvecio You are right, but this cannot happen before #5087 gets merged...

avatar zero-24 zero-24 - change - 29 Dec 2014
Rel_Number 5087
Relation Type Not before
avatar brianteeman brianteeman - change - 1 Jan 2015
Labels Removed: ?
avatar dgt41 dgt41 - change - 12 Mar 2015
Status Needs Review Closed
Closed_Date 2015-03-12 19:18:48 2015-08-17 23:51:49
Closed_By dgt41
avatar dgt41 dgt41 - change - 12 Mar 2015
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2015-03-12 19:18:48
avatar dgt41 dgt41 - change - 12 Mar 2015
Closed_Date 0000-00-00 00:00:00 2015-03-12 19:18:48
avatar dgt41 dgt41 - close - 12 Mar 2015
avatar dgt41 dgt41 - close - 12 Mar 2015
avatar dgt41 dgt41 - close - 12 Mar 2015

Add a Comment

Login with GitHub to post a comment