[#46449] - [5.4] Better code for save2copy Smart Search Filter
- Closed
- 17 Nov 2025
- Medium
- Build: 5.4-dev
- # 46449
- Diff
- joomdonation:improve_smart_search_filter_code
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This is a follow PR for #46081. There are few problems with that PR:
- It introduces some new methods (with different logic) to instead of re-using the same logic which is using everywhere in Joomla to generate new Alias on Save As Copy
- It does not handle the case Title is changed before As as Copy button is clicked
Testing Instructions
- Uses Joomla 5.4 nightly build
- Access to Components -> Smart Search -> Filters and create a new filter if none exists yet
- Click on a filter to edit, then use Save as Copy button to create a new filter. Make sure the Title and Alias are generated properly like Save as Copy as other places in Joomla (for example, Save as Copy article)
Actual result BEFORE applying this Pull Request
Works, but code is complicated than it should
Expected result AFTER applying this Pull Request
Works, with simpler to maintain code
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
I have tested this item ✅ successfully on 8640a46
I have tested this successfully.
I just want to be specific if the Filter is called:
Filter PR 46449 - Test, it works as expected and you get an alias of filter-pr-46449-test and if you Save as Copy, you then get:
Filter PR 46449 - Test (2), it works as expected and you get an alias of filter-pr-46449-test-2
BUT if you have an Title that ends in a number like:
Filter PR 46449, the alias will be filter-pr-46449 and if you Save as Copy, you then get:
Filter PR 46449 (2), the alias will be filter-pr-46450 and if you do it again, you then get:
Filter PR 46449 (3), the alias will be filter-pr-46451
This happens the same in other areas of Joomla so it is not an issue with this PR, that's why I validated the test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46449.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46449.
so good
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46449.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-11-17 15:18:11 |
| Closed_By | ⇒ | joomdonation | |
| Labels |
Added:
RTC
RMDQ
|
||
I'm closing this PR because maintainers decided to revert the original PR and implement a better/proper solution for 6.1
I have tested this item ✅ successfully on 8640a46
Tested with JBT, before PR with nightly build and second timne by applying the PR with Patch Tester
'Save as Copy' is working in creating '* (2)', '* (3)' ... entries, no problems in Joomla logs seen, nothing in PHP log
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46449.