[#46435] - [5.4] Preventing notices for broken images
- Fixed in Code Base
- 11 Nov 2025
- Medium
- Build: 5.4-dev
- # 46435
- Diff
- joomla:5.4-nonimage
- Pending continuous-integration/drone/push Build is running Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43279 .
Summary of Changes
When there is a file in the /images folder with less than apparently 12 bytes content, the functions we are using to get information about the images are throwing notices, breaking the JSON of the media manager. According to the documentation on php.net, the methods expect files with at least 12 bytes length to work.
Testing Instructions
- Create an empty file with an image extension (for example
test.gif) in the/imagesfolder - Go to media manager
Actual result BEFORE applying this Pull Request
No images are displayed. If you open the developer tools, you see that the ajax request returned a broken JSON with some notices at the beginning.
Expected result AFTER applying this Pull Request
No notices, working media manager
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I am marking this as successful because it removes the errors etc but I think it can be improved
I did expect that it would still display the filename with the icon-eye-slash icon as it does with other files it cannot determine but instead there is nothing listed at all.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46435.
The reason for the request for improvement is because if the invalid image is still listed in the media manager it can be selected and therefore deleted.
I have tested this item ✅ successfully on 89b1c58
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46435.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46435.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-11-11 12:59:20 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
RTC
|
||
@Hackwar Thanks for fixing this bug, and thanks @brianteeman for testing.
Can you tell me if this fix will be automatically added to Joomla 6?
Can you tell me if this fix will be automatically added to Joomla 6?
@korenevskiy You should know that meanwhile as you are not new here. YOu can clearly see that this PR has been merged into 5.4-dev and so it will be in the next release 5.4.1, and it is also merged up into 6.0-dev and will be in the next release 6.0.1. Both are scheduled for November 25, see roadmap here https://developer.joomla.org/roadmap.html , and release candidates for these versions are already available.
@richard67 Thank you so much for clarifying. I didn't find on the website how to see that PR is linked to 2 branches at once, but I will know this for the future. Thank you very much for the clarification.
I have tested this item ✅ successfully on 89b1c58
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46435.