Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4643] - [Code Style] Changes in tag standards: mix

? ? Success

User tests: Successful: Unsuccessful:

avatar javigomez
javigomez
12 Oct 2014

This pull should fix the issue detailed here: joomla/coding-standards#80

I have broken in parts this original pull #4590 to make it easy for review. This pull is contains only the mix of latest files to remove the @package and @subpackage tags.

The rest of the changes were sent in different pulls: #4603, #4625, #4632, #4636, #4637, #4639 and #4617.

avatar javigomez javigomez - open - 12 Oct 2014
avatar jissues-bot jissues-bot - change - 12 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 12 Oct 2014
Category ⇒ Code style Components
avatar brianteeman brianteeman - change - 12 Oct 2014
Category Code style Components ⇒ Code style
avatar infograf768
infograf768 - comment - 13 Oct 2014

Travis fails

avatar javigomez javigomez - change - 13 Oct 2014
Labels Added: ?
avatar wilsonge
wilsonge - comment - 13 Oct 2014

Just needs https://github.com/joomla/joomla-cms/pull/4643/files#diff-2005bc96db296e43bea8949a653ae346R166 spacing to be fixed. Nothing major

avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar javigomez
javigomez - comment - 16 Oct 2014

Updating the pulls with the fix for @wilsonge comment and with the change that Michael did in the Sniffs. I guess it should pass now.

avatar nicksavov
nicksavov - comment - 17 Oct 2014

Still fails

avatar nicksavov nicksavov - change - 17 Oct 2014
Labels Removed: ?
avatar mbabker
mbabker - comment - 17 Oct 2014

It's fine, the fail is a bad copy/paste job on one of the tests I was working with.

avatar Bakual
Bakual - comment - 20 Oct 2014

Merged into staging. Thanks!

avatar javigomez javigomez - close - 20 Oct 2014
avatar javigomez javigomez - change - 20 Oct 2014
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-10-20 12:54:52

Add a Comment

Login with GitHub to post a comment