NPM Resource Changed PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
9 Nov 2025

Pull Request for Issue # .

Summary of Changes

This pull request (PR) fixes one low severity and 3 moderate severity security vulnerabilities in indirect NPM development dependencies reported by npm audit by using npm audit fix.

Testing Instructions

It needs a development environment with a git clone, composer and npm.

  1. If not done before, run composer install and npm ci.
  2. Run npm audit.
  3. Check the result.

Actual result BEFORE applying this Pull Request

# npm audit report

min-document  <=2.19.0
min-document vulnerable to prototype pollution - https://github.com/advisories/GHSA-rx8g-88g5-qh64
fix available via `npm audit fix`
node_modules/min-document

nodemailer  <7.0.7
Severity: moderate
Nodemailer: Email to an unintended domain can occur due to Interpretation Conflict - https://github.com/advisories/GHSA-mm7p-fcc7-pg87
fix available via `npm audit fix`
node_modules/nodemailer
node_modules/smtp-server/node_modules/nodemailer
  mailparser  2.3.1 - 3.7.4
  Depends on vulnerable versions of nodemailer
  node_modules/mailparser
  smtp-server  2.0.0 - 3.14.0
  Depends on vulnerable versions of nodemailer
  node_modules/smtp-server

tinymce  <7.0.0
Severity: moderate
TinyMCE Cross-Site Scripting (XSS) vulnerability in handling external SVG files through Object or Embed elements - https://github.com/advisories/GHSA-5359-pvf2-pw78
fix available via `npm audit fix --force`
Will install tinymce@8.2.1, which is a breaking change
node_modules/tinymce

5 vulnerabilities (1 low, 4 moderate)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Expected result AFTER applying this Pull Request

# npm audit report

tinymce  <7.0.0
Severity: moderate
TinyMCE Cross-Site Scripting (XSS) vulnerability in handling external SVG files through Object or Embed elements - https://github.com/advisories/GHSA-5359-pvf2-pw78
fix available via `npm audit fix --force`
Will install tinymce@8.2.1, which is a breaking change
node_modules/tinymce

1 moderate severity vulnerability

To address all issues (including breaking changes), run:
  npm audit fix --force

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 9 Nov 2025
avatar richard67 richard67 - change - 9 Nov 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2025
Category NPM Change
avatar brianteeman
brianteeman - comment - 9 Nov 2025

When I check the values of package-lock.json after locally running npm audit I have one additional change not present in this pr

image
avatar richard67
richard67 - comment - 9 Nov 2025

When I check the values of package-lock.json after locally running npm audit I have one additional change not present in this pr
image

@brianteeman Maybe your branch was not up to date? If you check the file in my PR you will see the versions are already 5.4.1:

{
"name": "joomla",
"version": "5.4.1",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "joomla",
"version": "5.4.1",
"hasInstallScript": true,
"license": "GPL-2.0-or-later",
"dependencies": {

avatar brianteeman
brianteeman - comment - 9 Nov 2025

must have been thatsorry for the noise

avatar brianteeman brianteeman - test_item - 9 Nov 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 9 Nov 2025

I have tested this item ✅ successfully on a6f240f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46429.

avatar richard67
richard67 - comment - 9 Nov 2025

@brianteeman Thanks for testing.

avatar muhme muhme - test_item - 10 Nov 2025 - Tested successfully
avatar muhme
muhme - comment - 10 Nov 2025

I have tested this item ✅ successfully on a6f240f

Tested with JBT

  • Seen the 5 vulnerabilities (1 low, 4 moderate) before
  • Applied PR with gh pr checkout 46429 and running npm audit report shows the 1 moderate severity vulnerability
  • Gone back with git switch -, updated NPM with npm install -g npm@latest and did npm audit fix by own and got exactly the same package-lock.json file
    This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46429.
avatar muhme muhme - change - 10 Nov 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-11-10 06:19:43
Closed_By muhme
Labels Added: NPM Resource Changed PR-5.4-dev
avatar muhme muhme - close - 10 Nov 2025
avatar muhme muhme - merge - 10 Nov 2025
avatar muhme
muhme - comment - 10 Nov 2025

Thank you @richard67 for your contribution. Thank you @brianteeman for testing.

Add a Comment

Login with GitHub to post a comment