[#46423] - [5.4] php 8.4 fputcsv
- Ready to Commit
- Medium
- Build: 5.4-dev
- # 46423
- Diff
- brianteeman:escape2
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
In PHP 8.4, not passing the $escape parameter emits a deprecation notice. Passing the $escape parameter explicitly avoids the deprecation notice.
Testing Instructions
Using php 8.4 go to action logs and export, Check the export
Actual result BEFORE applying this Pull Request
Deprecation notice
<b>Deprecated</b>: fputcsv(): the $escape parameter must be provided as its default value will change in <b>D:\repos\j6\administrator\components\com_actionlogs\src\Controller\ActionlogsController.php</b> on line <b>113</b><br />
Expected result AFTER applying this Pull Request
No deprecation notice
Reference https://php.watch/versions/8.4/csv-functions-escape-parameter
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
I have tested this item ✅ successfully on 652f2f2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46423.
| Labels |
Added:
bug
PR-5.4-dev
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46423.
I have tested this item ✅ successfully on 652f2f2
I have tested this successfully :) Thks @brianteeman for the fix!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46423.