PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
6 Nov 2025

Pull Request for Issue # .

Summary of Changes

In PHP 8.4, not passing the $escape parameter emits a deprecation notice. Passing the $escape parameter explicitly avoids the deprecation notice.

Testing Instructions

Using php 8.4 go to action logs and export, Check the export

Actual result BEFORE applying this Pull Request

Deprecation notice
<b>Deprecated</b>: fputcsv(): the $escape parameter must be provided as its default value will change in <b>D:\repos\j6\administrator\components\com_actionlogs\src\Controller\ActionlogsController.php</b> on line <b>113</b><br />

Expected result AFTER applying this Pull Request

No deprecation notice

Reference https://php.watch/versions/8.4/csv-functions-escape-parameter

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 6 Nov 2025
avatar brianteeman brianteeman - change - 6 Nov 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2025
Category Administration
avatar richard67
richard67 - comment - 8 Nov 2025

@brianteeman Shouldn't that be fixed in 5.4-dev (and then be merged up into 6.0-dev by RMs)? The issue applies to 5.4-dev, see https://github.com/joomla/joomla-cms/blob/5.4-dev/administrator/components/com_actionlogs/src/Controller/ActionlogsController.php#L113 .

avatar brianteeman brianteeman - change - 8 Nov 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-11-08 10:08:54
Closed_By brianteeman
Labels Added: PR-6.0-dev
avatar brianteeman brianteeman - close - 8 Nov 2025
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2025
Category Administration Repository Administration com_admin SQL
avatar brianteeman
brianteeman - comment - 8 Nov 2025

cant downgrade on a rebase - new pr #46423

Add a Comment

Login with GitHub to post a comment