[#46412] - [6.1] Refactor subform rendering with fieldsets support
- Pending
- Medium
- Build: 6.1-dev
- # 46412
- Diff
- BrainforgeUK:patch-1
User tests: Successful: Unsuccessful:
groupByFieldset functionality added.
Summary of Changes
Setting groupByFieldset parameter in XML to true does not currently serve any purpose.
This change (without any other fieldset parameters) uses CSS grid display to group fields in a fieldset.
Additional parameters can be used with the fieldset(s) can be used to customise how the fields are grouped (e.g. use flex instead of grid).
Testing Instructions
Install the following plugins:
bfsubfieldtest1.zip
bfsubfieldtest2.zip
bfsubfieldtest3.zip
Actual result BEFORE applying this Pull Request
Go to plugin admin page.
Unexpected result - there is no difference between bfsubfieldtest1 and bfsubfieldtest2.
Expected result AFTER applying this Pull Request
Go to plugin admin page.
With bfsubfieldtest2 the the fields are now grouped by fieldset.
bfsubfieldtest3 illustrates how the appearance of fields grouped within fieldsets can be customised.
Link to documentations
The code in this pull request includes comments about the available fieldset attributes. These comments together with the example subform fields from bfsubfieldtest3 need to be included in the documentation.
Please select:
-
[*] Documentation link for docs.joomla.org:
Avanced Form Guide
Subform Form Field -
[] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
PR-6.1-dev
|
||
Screenshots added.
Test performed successfully.
bfsubfieldtest1, bfsubfieldtest2, bfsubfieldtest3 as shown in the images.
I have tested this item ✅ successfully on 96e61e3
Test performed successfully.
bfsubfieldtest1, bfsubfieldtest2, bfsubfieldtest3 as shown in the images.
SEE: #46412 (comment)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46412.
I have tested this item ✅ successfully on 96e61e3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46412.
I have tested this item ✅ successfully on 96e61e3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46412.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46412.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46412.
Sorry but this pull request is wrong - we should not be introducing inline styles
Also it completely breaks the layout on mobile devices
I have tested this item 🔴 unsuccessfully on 96e61e3
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46412.
| Status | Ready to Commit | ⇒ | Pending |
no r2c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46412.
I have tested this item ✅ successfully on 96e61e3
I have tested this item ✅ successfully on 96e61e3
The fieldset grouping works as expected on all three test plugins. Fields are properly grouped and customizable via fieldset parameters.
Test environment:
- Browser: Brave
- Joomla: 6.1-dev
- Tested: Desktop and mobile layouts
Note: Did not observe the mobile layout issues mentioned by @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46412.
Setting the "Updates requested" label as there are unresolved issues, see this comment and this comment above:
Sorry but this pull request is wrong - we should not be introducing inline styles
Also it completely breaks the layout on mobile devices
| Labels |
Added:
Feature
Updates Requested
|
||
I don't quite understand the testing instructions! The diff shows changes to layouts/joomla/form/field/subform/default.php - perhaps a screenshot would help.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46412.