[#4641] - Travis is now failing
- Closed
- 12 Oct 2014
- Medium
- Build: master
- # 4641
I think travis is now failing because of all this changes: #4603, #4625, #4632, #4636, #4637 and #4617... that were done to fix: joomla/coding-standards#80
I'm assigning to you @mbabker because you know it works to remove the sniffer from the ruleset that requires the @package and @subpackage in Class. Or maybe to even add a sniffer that ensures that there is no @package and @subpackage tags in class.
Where is it failing at? The current builds on staging have all passed and I only see a couple of PRs with failures. Specifically checked the build for #4637 and it passed - https://travis-ci.org/joomla/joomla-cms/builds/37752124
zero-24
- 
Thanks ^_^
@mbabker If I understand this change correctly it only removes the requirement of the @package and @subpackage tags in the class docblock. I believe we need to enhance it even further as @javigomez said:
Or maybe to even add a sniffer that ensures that there is no @package and @subpackage tags in class.
We should enforce the coding standard as much as possible.
IMO it's fine as it is. The change removes the requirement for the tag to be there, but won't raise an error if someone optionally uses it. If we made the change in the main coding standard to disallow the tag completely, it would throw errors if someone wanted to optionally use it.
@mbabker can this be closed now?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4641.
It's already closed?
Weird it was showing as open before on jissues, but not now. I wouldnt have found it otherwise
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4641.
| Labels |
Added:
?
|
||