User tests: Successful: Unsuccessful:
The method loads the profile info for the linked user even when no user is linked ($contact->user_id == 0), loading unnecessary stuff (UserModel, form, data, plugin) for nothing.
Pull Request for Issue # .
Conditions the request of Contact Linked profile data and functions to the existence of a linked user
Create a contact item and test linking it or not to a user
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Front End com_contact |
| Title |
|
||||||
| Labels |
Added:
PR-5.4-dev
|
||
So with that fixed, the difference is ... what?
I see exactly the same result with and without the patch applied. And with and without a linked user.
@ceford As far as I understand this PR, there should not be a visible difference. Everything should work as well as before for the 2 cases (contact item without a linked user, and contact item with a linked user).
I have tested this item ✅ successfully on af75ef3
I have tested this item ✅ successfully on af75ef3
Tested with JBT
Applied PR with Patch Teser
| Status | Pending | ⇒ | Ready to Commit |
RTC
I have a problem! I created a contact named
Nobodyand left all of the fields blank. It is in Category: Sample Data-Contact and is Featured. I see it in a list of featured contacts along with two others. Selecting the link throes a 404 page with this call stack:Comparing two links:
http://localhost/joomla-cms5/index.php/en/contact-component/contact-categories/park-site/webmaster
http://localhost/joomla-cms5/index.php/en/contact-component/contact-categories/nobody
Ah! Wrong parent category.
So with that fixed, the difference is ... what?
I see exactly the same result with and without the patch applied. And with and without a linked user.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46398.