Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
30 Oct 2025

Summary of Changes

New addControlField() method has $value as empty string by default, no sense to use empty string in method calls.

image

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

useless default param in code

Expected result AFTER applying this Pull Request

No changes.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Denitz Denitz - open - 30 Oct 2025
avatar Denitz Denitz - change - 30 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2025
Category Administration com_associations com_banners com_cache com_categories com_checkin com_config com_contact com_content com_fields com_finder com_installer
avatar RickR2H RickR2H - test_item - 14 Nov 2025 - Tested successfully
avatar RickR2H
RickR2H - comment - 14 Nov 2025

I have tested this item ✅ successfully on 1fbc46d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46381.

avatar richard67
richard67 - comment - 24 Nov 2025

Such bigger refactoring should not be done in a patch version, so this PR would have to be made for 6.1-dev, I think.

@softforge @Bodge-IT Please check and decide.

avatar HLeithner HLeithner - change - 24 Nov 2025
Title
Remove default empty string param in addControlField()
[6.0] Remove default empty string param in addControlField()
avatar HLeithner HLeithner - edited - 24 Nov 2025

Add a Comment

Login with GitHub to post a comment