[#46358] - [6.0] Fix article version history frontend
- Ready to Commit
- Medium
- Build: 6.0-dev
- # 46358
- Diff
- joomdonation:fix_article_version_history_frontend
User tests: Successful: Unsuccessful:
Pull Request for Issue #46352.
Summary of Changes
Currently, when articles are saved from frontend (could be the same for other content types like contacts, weblinks...), version history is not created. The reason is because $context (which we are using to identify content type) will be changed, depend on name of the model. We need to use $typeAlias property from model instead
Testing Instructions
- Use Joomla 6.0
- Edit articles from frontend, try to change it's data. Check it's version history, it is not created.
- Apply patch, try to make change, confirm that version history is created properly
- Please also try to edit articles, and contact from backend (just a quick test) and make sure version history is still being saved properly from there, too
Actual result BEFORE applying this Pull Request
Version History does not work from frontend.
Expected result AFTER applying this Pull Request
Version History works well for frontend.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
@richard67 Yes, I always do that :)
@richard67 Yes, I always do that :)
@joomdonation Thanks. I've asked because not all maintainers do that.
Update 6.0.0 to 6.0.1-dev+pr.46358
Article versions are now recreated in the frontend, both on save and save-as.
And article versions are still being created in the backend.
I also tested the contact component in the backend, and here too, versions are being created on save and save-as.
Didier.
@dpollez Thanks. Could you please go to https://issues.joomla.org/tracker/joomla-cms/46358 and mark your test result?
@dpollez Please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/46358 and mark your test result by using the blue "Test this" button at the top left corner, selecting your test result and then submitting. Each pull request needs 2 successful human test, and marking the test result makers sure that the test is properly counted. Thanks in advance.
I have tested this item ✅ successfully on f9a1c56
Update 6.0.0 to 6.0.1-dev+pr.46358
Article versions are now recreated in the frontend, both on save and save-as.
And article versions are still being created in the backend. I also tested the contact component in the backend, and here too, versions are being created on save and save-as.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46358.
I came across this "version error" while checking whether PR 45254 had been fixed in version 6, which unfortunately wasn't.
This is a very annoying error that makes front-end changes very confusing.
Will this be fixed? I reported this back in March, and others even earlier.
See #45254
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46358.
I came across this "version error" while checking whether PR 45254 had been fixed in version 6, which unfortunately wasn't. This is a very annoying error that makes front-end changes very confusing. Will this be fixed? I reported this back in March, and others even earlier. See #45254
I haven't looked at that one, so I don't know. Usually, thing with routing is harder to fix, so please be patient.
I have tested this item ✅ successfully on f9a1c56
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46358.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-6.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46358.
@joomdonation Can you close the corresponding issue when having created a PR for it?