[#46353] - [6.0] Child templates extend language instead of override
- Pending
- Medium
- Build: 6.0-dev
- # 46353
- Diff
- dgrammatiko:6.0-dev/ttttmp
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Testing Instructions
- create a child template of cassiopeia
- copy the language file
- remove all the content of the language file in the child template
- copy the index.php from the cassiopeia to the child template
- add somewhere
<?= Text::_('TPL_CASSIOPEIA_BACKTOTOP'); ?>
Without the PR will get TPL_CASSIOPEIA_BACKTOTOP with the PR will get Back to Top
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-6.0-dev
|
||
maybe you find out why we load the language files twice
Probably has to do with the other document types (the HtmlDocument class is loading the language files I have to check the other ones)
@dgrammatiko could you please add some test instructions?
| Title |
|
||||||
Hi @dgrammatiko,
I have tried following the Testing Instructions to the letter so either it's not working, or I misunderstood something or there's a step missing?
Image shows the folder/file structure with Child Template for PR46353, index.php copied and Language Folders en-GB and fr-FR emptied
Image shows Child Template for PR46353 selected (wasn't mentioned in Testing Instructions but assumed that was needed)
PR NOT Applied, yet Back to Top showing and not TPL_CASSIOPEIA_BACKTOTOP
HELP? ;)
You shouldn’t empty the folders but the files (.ini). Ie files should exist but with no content
You shouldn’t empty the folders but the files (.ini). Ie files should exist but with no content
Ah, ok. Let me try that - thanks. That's a lot of files to empty lol, on it.
Thankfully, a bit of command line magic will do that trick:
for file in *.ini; do > "$file"; done
Unfortunately, @dgrammatiko, even after emptying the .ini files (while keeping them there), and NOT applying the PR, I still get Back to Top vs TPL_CASSIOPEIA_BACKTOTOP
Image showing .ini files present but 0 bytes...
(the rest of the .ini files in that folder are 0 bytes also as well as the .ini files in /fr-FR/ folder for other language on multi-lingual test site).
@dgrammatiko could you please update your instructions to make the steps clearer? That should help with tests.
Will try to do it after work
please simplify the if statements, the else is not needed and maybe you find out why we load the language files twice?