[#46353] - [6.1] Child templates extend language instead of override
- Pending
- Medium
- Build: 6.0-dev
- # 46353
- Diff
- dgrammatiko:6.0-dev/ttttmp
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Extend the existing parent language of the parent template instead of requiring to recreate the existing strings on the child template
Testing Instructions
- on the existing cassiopeia_extended create the language override:
- edit the file
templates/cassiopeia_extended/language/en-GB/tpl_cassiopeia_extended.iniand addCASSIOPEIA_TEST="Correct String"
- edit the file
templates/cassiopeia_extended/index.phpand add
echo Joomla\CMS\Language\Text::_('CASSIOPEIA_TEST');
echo '<br>';
echo Joomla\CMS\Language\Text::_('CASSIOPEIA');
- Make sure that Cassiopeia Extended is the default template (should have the yellow star)
- Visit the site, should see (with the PR applied)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-6.0-dev
|
||
maybe you find out why we load the language files twice
Probably has to do with the other document types (the HtmlDocument class is loading the language files I have to check the other ones)
@dgrammatiko could you please add some test instructions?
| Title |
|
||||||
Hi @dgrammatiko,
I have tried following the Testing Instructions to the letter so either it's not working, or I misunderstood something or there's a step missing?
Image shows the folder/file structure with Child Template for PR46353, index.php copied and Language Folders en-GB and fr-FR emptied
Image shows Child Template for PR46353 selected (wasn't mentioned in Testing Instructions but assumed that was needed)
PR NOT Applied, yet Back to Top showing and not TPL_CASSIOPEIA_BACKTOTOP
HELP? ;)
You shouldn’t empty the folders but the files (.ini). Ie files should exist but with no content
You shouldn’t empty the folders but the files (.ini). Ie files should exist but with no content
Ah, ok. Let me try that - thanks. That's a lot of files to empty lol, on it.
Thankfully, a bit of command line magic will do that trick:
for file in *.ini; do > "$file"; done
Unfortunately, @dgrammatiko, even after emptying the .ini files (while keeping them there), and NOT applying the PR, I still get Back to Top vs TPL_CASSIOPEIA_BACKTOTOP
Image showing .ini files present but 0 bytes...
(the rest of the .ini files in that folder are 0 bytes also as well as the .ini files in /fr-FR/ folder for other language on multi-lingual test site).
@dgrammatiko could you please update your instructions to make the steps clearer? That should help with tests.
Will try to do it after work
Will try to do it after work
Hi @dgrammatiko
I've assigned you to this PR, maybe you'll get around to it and then I'd like to label it with pbf.
| Labels |
Added:
Updates Requested
|
||
| Title |
|
||||||
| Labels |
Added:
PR-6.1-dev
|
||
| Labels |
Removed:
PR-6.0-dev
|
||
maybe you find out why we load the language files twice
Probably has to do with the other document types (the HtmlDocument class is loading the language files I have to check the other ones)
I remember having seen another PR or issue about that, but I am not sure, maybe I mix something up.
I remember having seen another PR or issue about that, but I am not sure, maybe I mix something up.
You mean #46518 but that was specific to the com_templates. Also this PR is doing something fundamentally different and now I have to do another PR to align that code with this one...
I remember having seen another PR or issue about that, but I am not sure, maybe I mix something up.
You mean #46518 but that was specific to the com_templates. Also this PR is doing something fundamentally different and now I have to do another PR to align that code with this one...
@dgrammatiko No, not that one. It was something with double load or double render or rendered twice.
I have tested this item 🔴 unsuccessfully on 20e1768
Tested this during PBF, with Olivier watching, I have followed your instructions and matched each screen shot EXCEPT that the BEFORE PR condition shows:
Correct String
Cassiopeia Site template
and the version with the PR applied shows the same thing 😭 - sorry.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46353.
I agree with @exlemor
I got the same result.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46353.
Getting the same result as exlemor and idefax.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46353.
I did retest on my own environment with still the same result.
Are the testing instructions correct?
Both before and after should be the same, my bad!
OK, in this case my testing was succsessful!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46353.
I have tested this item ✅ successfully on 20e1768
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46353.
Both before and after should be the same, my bad!
Hi @dgrammatiko, could you update the Testing Instructions so that it clears up the issue - if the results are SUPPOSED to be the same BEFORE and AFTER PR, then I can re-test as successful :)
I have tested this item ✅ successfully on 20e1768
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46353.
I have tested this item ✅ successfully on 20e1768
Thank you @dgrammatiko for updating the Testing Instructions - since now the BEFORE and AFTER results are the same, I have been able to test this successfully! 💪👍
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46353.
please simplify the if statements, the else is not needed and maybe you find out why we load the language files twice?