RTC Language Change bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 Oct 2025

Pull Request for Issue #45680

Summary of Changes

Slight language tweak to the two error strings related to the php temporary folder either not being set or not being writeable. Makes the message more specific by explictly writing "upload_tmp_dir"

I see this as a minor tweak/improvement and doesnt change the meaning of the original string so it is fully b/c

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 20 Oct 2025
avatar brianteeman brianteeman - change - 20 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2025
Category Administration Language & Strings
avatar richard67
richard67 - comment - 21 Oct 2025

Does this PR close the referred issue #45680 ?

avatar brianteeman
brianteeman - comment - 21 Oct 2025

It does as far as I am concerned

avatar richard67 richard67 - change - 25 Oct 2025
The description was changed
Status Pending Ready to Commit
Labels Added: Language Change PR-5.4-dev
avatar richard67
richard67 - comment - 25 Oct 2025

RTC after 2 review approvals.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46337.

avatar richard67 richard67 - edited - 25 Oct 2025
avatar richard67 richard67 - change - 25 Oct 2025
Labels Added: RTC bug
avatar muhme
muhme - comment - 25 Oct 2025

✅ Final test before merge with JBT, seen the error messages in System > Warning before PR with

  • With upload_tmp_dir = "/tmp/upload" and upload_tmp_dir = after:
mkdir /tmp/update && chmod 0 /tmp/update

Installed patch with gh pr checkout 46337 && npm ci

  • Checked both error messages, see sample:
test
avatar muhme muhme - change - 25 Oct 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-10-25 17:24:42
Closed_By muhme
avatar muhme muhme - close - 25 Oct 2025
avatar muhme muhme - merge - 25 Oct 2025
avatar muhme
muhme - comment - 25 Oct 2025

Thank you @brianteeman for your contribution. Thank you @tecpromotion and @richard67 for review.

Add a Comment

Login with GitHub to post a comment