PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
18 Oct 2025

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in script.php for the upcoming 5.4.1 release.

There is only one file /libraries/vendor/joomla/filter/PATCHES.txt added to the list.

That file was added to the 4.4.14 release for applying a security fix with the composer patch tool.

On 5.x that file should be removed.

As the file only exists on 5.x sites updated from 4.4.14 and never was releases in any 5.x release, the file is added to the // From 4.4 to 5.0 section in script.php like e.g. any 4.x update SQL scripts) and not to a new section // From 5.4.0 to 5.4.1.

Testing Instructions

Code review.

Or compare the 5.4.0 full installation zip with the 4.4.14 full installation zip and check if it contains file /libraries/vendor/joomla/filter/PATCHES.txt.

Or update from 4.4.14 to the latest 5.4 nightly build to check the actual result, and update from 4.4.14 to the patched package created by Drone for this PR to check the expected result.

Actual result BEFORE applying this Pull Request

File /libraries/vendor/joomla/filter/PATCHES.txt is in the 4.4.14 full installation zip but not in the 5.4.0 full installation zip.

When updating from 4.4.14 to 5.4.x, the file is still there after the update.

Expected result AFTER applying this Pull Request

When updating from 4.4.14 to 5.4.x, file /libraries/vendor/joomla/filter/PATCHES.txt is not present after the update.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 18 Oct 2025
avatar richard67 richard67 - change - 18 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2025
Category Administration com_admin
avatar richard67
richard67 - comment - 18 Oct 2025

@muhme Can be merged by review.

avatar richard67 richard67 - change - 18 Oct 2025
The description was changed
avatar richard67 richard67 - edited - 18 Oct 2025
avatar muhme
muhme - comment - 19 Oct 2025

✅ Tested with JBT recreate 4.4.14

  • Seen libraries/vendor/joomla/filter/PATCHES.txt file, manual instance update with nigthty 5.4.1-dev update ZIP, file still exists
  • Tested again with manual instance update from this PR update package, update is working w/o problems (checked Home Dashboard, Joomla and PHP log files) and file is no more existing
avatar muhme muhme - close - 19 Oct 2025
avatar muhme muhme - merge - 19 Oct 2025
avatar muhme muhme - change - 19 Oct 2025
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-10-19 04:38:19
Closed_By muhme
Labels Added: PR-5.4-dev
avatar muhme
muhme - comment - 19 Oct 2025

Thank you @richard67 for your contribution.

Add a Comment

Login with GitHub to post a comment