User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) updates the list of files to be deleted on update in script.php for the upcoming 5.4.1 release.
There is only one file /libraries/vendor/joomla/filter/PATCHES.txt added to the list.
That file was added to the 4.4.14 release for applying a security fix with the composer patch tool.
On 5.x that file should be removed.
As the file only exists on 5.x sites updated from 4.4.14 and never was releases in any 5.x release, the file is added to the // From 4.4 to 5.0 section in script.php like e.g. any 4.x update SQL scripts) and not to a new section // From 5.4.0 to 5.4.1.
Code review.
Or compare the 5.4.0 full installation zip with the 4.4.14 full installation zip and check if it contains file /libraries/vendor/joomla/filter/PATCHES.txt.
Or update from 4.4.14 to the latest 5.4 nightly build to check the actual result, and update from 4.4.14 to the patched package created by Drone for this PR to check the expected result.
File /libraries/vendor/joomla/filter/PATCHES.txt is in the 4.4.14 full installation zip but not in the 5.4.0 full installation zip.
When updating from 4.4.14 to 5.4.x, the file is still there after the update.
When updating from 4.4.14 to 5.4.x, file /libraries/vendor/joomla/filter/PATCHES.txt is not present after the update.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_admin |
✅ Tested with JBT recreate 4.4.14
libraries/vendor/joomla/filter/PATCHES.txt file, manual instance update with nigthty 5.4.1-dev update ZIP, file still exists| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-10-19 04:38:19 |
| Closed_By | ⇒ | muhme | |
| Labels |
Added:
PR-5.4-dev
|
||
Thank you @richard67 for your contribution.
@muhme Can be merged by review.