[#46286] - [5.4][6.0] Fix installation error on Windows
- Fixed in Code Base
- 19 Oct 2025
- Medium
- Build: 5.4-dev
- # 46286
- Diff
- joomdonation:fix_installation_errors
User tests: Successful: Unsuccessful:
Pull Request for Issue #46284.
Summary of Changes
At the end of the installation process, Joomla attempts to delete the installation folder.
On Windows, this operation consistently throws a FilesystemException because PHP locks the currently executing index.php file, preventing its immediate removal.
The exception was not caught, causing a fatal error and breaking the cleanup process.
This PR fixes the issue by wrapping the folder deletion in a try/catch block and returning false when an exception is thrown, instead of letting it crash.
Additionally, a Windows-specific workaround has been added:
if the installation folder contains no subfolders and only the (already deleted but still locked) index.php file, we can assume the deletion was effectively successful and continues the cleanup process.
Testing Instructions
- You can only see the issue and test this PR on Windows
- Follow instructions at #46284, confirm the issue
- You cannot test this using Patch Tester, unfortunately. You can test it by download Joomla 5.4 from https://downloads.joomla.org/cms/joomla5/, then replace the file installation/src/Model/CleanupModel.php with the modified file in this PR, then run the installation and make sure the error is gone.
Actual result BEFORE applying this Pull Request
- Error while installing Joomla on Windows
Expected result AFTER applying this Pull Request
- The error is fixed
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
PS: I used ChatGTP to improve the PR description and code comment to make it more clear :D. It provides better, clear messages than mine :D
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 77e58b5
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46286.
Or get a fresh installation of Joomla 5.4, then replace the file installation/src/Model/CleanupModel.php in the package with the file change in this PR as I wrote in testing instructions. I do not know if there is an easier way to test this.
I have tested this item ✅ successfully on 77e58b5
Had to setup XAMPP on Windows to be able to reproduce the issue as it doesn't happen with Linux.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46286.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46286.
| Labels |
Added:
RTC
bug
|
||
✅ Final test before merge with localhost Joomla installation on Windows 11-Pro, Laragon 6.0
- Installed from nigthly full package, Disabled Automated Updates
- Tried to delete installation folder getting error
Beim Abrufen von JSON-Daten wurde ein HTTP-Statuscode 500 zurückgegeben. Internal Server Error
and folderinstallationis not deleted - 2nd installation from PRs full package is working without any errors and the
installationfolder is emptied
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-10-19 08:31:09 |
| Closed_By | ⇒ | muhme |
Thank you @joomdonation for your contribution. Thank you @richard67 and @brianteeman for your support and testing.
Thanks, everyone !
You cant test this properly with the download in this pr as that still has the dev_status=development and that needs to be manually changed before trying to install