User tests: Successful: Unsuccessful:
Pull Request for Issue #46271 .
Changes a space to a tab to ensure that all columns are separated by a tab.
Code Review
The priotiy and ip address columns have a space as a separator when all the other columns are tab separated
All columns are tab separated
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
The same here?
Not at my pc but if that's also mixed spaces and tabs then please open a new issue
| Labels |
Added:
bug
PR-5.4-dev
|
||
| Category | Libraries | ⇒ | Libraries Front End Plugins |
added webauthn log
I have tested this item ✅ successfully on 16d123c
added webauthn log
thanks
I have tested this item ✅ successfully on 16d123c
| Status | Pending | ⇒ | Ready to Commit |
RTC
| Labels |
Added:
RTC
|
||
Final check before merge: ✅ All spaces are replaces by tabs.
@brianteeman And is it not better to use \t as in other places? This would be clearly visible when reading the code in any case (independed from editor and configuration). After applying the PR, we could search and find:
find . -name \*.php | xargs grep "{MESSAGE}" | sed 's/\t/→/g'
./plugins/system/webauthn/src/Extension/Webauthn.php: 'text_entry_format' => '{DATETIME}→{PRIORITY}→{CLIENTIP}→{MESSAGE}',
./libraries/src/Log/Logger/FormattedtextLogger.php: protected $format = '{DATETIME}→{PRIORITY}→{CLIENTIP}→{CATEGORY}→{MESSAGE}';
./libraries/src/Log/Logger/W3cLogger.php: protected $format = '{DATE}→{TIME}→{PRIORITY}→{CLIENTIP}→{CATEGORY}→{MESSAGE}';
./installation/includes/app.php: 'format' => '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}',
./installation/includes/cli.php: 'format' => '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}',
./administrator/components/com_scheduler/src/Scheduler/Scheduler.php: $options['text_entry_format'] = '{DATE}→{TIME}→{PRIORITY}→{MESSAGE}';
./administrator/components/com_scheduler/src/Task/Task.php: $options['text_entry_format'] = '{DATE}→{TIME}→{PRIORITY}→{MESSAGE}';
./administrator/components/com_joomlaupdate/src/Model/UpdateModel.php: 'format' => '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}',
./administrator/components/com_finder/src/Response/Response.php: $options['format'] = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
./administrator/components/com_finder/src/Controller/IndexerController.php: $options['format'] = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
./administrator/components/com_finder/src/Controller/IndexerController.php: $options['format'] = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
./administrator/components/com_finder/src/Controller/IndexerController.php: $options['format'] = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-10-17 12:55:31 |
| Closed_By | ⇒ | richard67 |
Thanks all (author and testers).
I have tested this item ✅ successfully on c46fe44
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46273.