RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
12 Oct 2025

Pull Request for Issue #46271 .

Summary of Changes

Changes a space to a tab to ensure that all columns are separated by a tab.

Testing Instructions

Code Review

Actual result BEFORE applying this Pull Request

The priotiy and ip address columns have a space as a separator when all the other columns are tab separated

Expected result AFTER applying this Pull Request

All columns are tab separated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 12 Oct 2025
avatar brianteeman brianteeman - change - 12 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2025
Category Libraries
avatar alikon alikon - test_item - 12 Oct 2025 - Tested successfully
avatar alikon
alikon - comment - 12 Oct 2025

I have tested this item ✅ successfully on c46fe44


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46273.

avatar heelc29
heelc29 - comment - 12 Oct 2025

The same here?

'text_entry_format' => '{DATETIME} {PRIORITY} {CLIENTIP} {MESSAGE}',

avatar brianteeman
brianteeman - comment - 12 Oct 2025

Not at my pc but if that's also mixed spaces and tabs then please open a new issue

avatar heelc29
heelc29 - comment - 12 Oct 2025

I do a quick test ... yes it looks like
image

then please open a new issue

Isn't it easier to integrate this into your PR since it's the same mistake

avatar brianteeman brianteeman - change - 12 Oct 2025
Labels Added: bug PR-5.4-dev
avatar joomla-cms-bot joomla-cms-bot - change - 12 Oct 2025
Category Libraries Libraries Front End Plugins
avatar brianteeman
brianteeman - comment - 12 Oct 2025

added webauthn log

avatar heelc29 heelc29 - test_item - 12 Oct 2025 - Tested successfully
avatar heelc29
heelc29 - comment - 12 Oct 2025

I have tested this item ✅ successfully on 16d123c

added webauthn log

thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46273.

avatar sergeytolkachyov sergeytolkachyov - test_item - 13 Oct 2025 - Tested successfully
avatar sergeytolkachyov
sergeytolkachyov - comment - 13 Oct 2025

I have tested this item ✅ successfully on 16d123c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46273.

avatar richard67 richard67 - change - 13 Oct 2025
The description was changed
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 13 Oct 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46273.

avatar richard67 richard67 - edited - 13 Oct 2025
avatar richard67 richard67 - change - 17 Oct 2025
Labels Added: RTC
avatar muhme
muhme - comment - 17 Oct 2025

Final check before merge: ✅ All spaces are replaces by tabs.

@brianteeman And is it not better to use \t as in other places? This would be clearly visible when reading the code in any case (independed from editor and configuration). After applying the PR, we could search and find:

find . -name \*.php | xargs grep "{MESSAGE}" | sed 's/\t/→/g'           
./plugins/system/webauthn/src/Extension/Webauthn.php:            'text_entry_format' => '{DATETIME}→{PRIORITY}→{CLIENTIP}→{MESSAGE}',
./libraries/src/Log/Logger/FormattedtextLogger.php:    protected $format = '{DATETIME}→{PRIORITY}→{CLIENTIP}→{CATEGORY}→{MESSAGE}';
./libraries/src/Log/Logger/W3cLogger.php:    protected $format = '{DATE}→{TIME}→{PRIORITY}→{CLIENTIP}→{CATEGORY}→{MESSAGE}';
./installation/includes/app.php:            'format'    => '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}',
./installation/includes/cli.php:            'format'    => '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}',
./administrator/components/com_scheduler/src/Scheduler/Scheduler.php:        $options['text_entry_format'] = '{DATE}→{TIME}→{PRIORITY}→{MESSAGE}';
./administrator/components/com_scheduler/src/Task/Task.php:            $options['text_entry_format'] = '{DATE}→{TIME}→{PRIORITY}→{MESSAGE}';
./administrator/components/com_joomlaupdate/src/Model/UpdateModel.php:            'format'    => '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}',
./administrator/components/com_finder/src/Response/Response.php:            $options['format']    = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
./administrator/components/com_finder/src/Controller/IndexerController.php:            $options['format']    = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
./administrator/components/com_finder/src/Controller/IndexerController.php:            $options['format']    = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
./administrator/components/com_finder/src/Controller/IndexerController.php:            $options['format']    = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
avatar richard67 richard67 - change - 17 Oct 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-10-17 12:55:31
Closed_By richard67
avatar richard67 richard67 - close - 17 Oct 2025
avatar richard67 richard67 - merge - 17 Oct 2025
avatar richard67
richard67 - comment - 17 Oct 2025

Thanks all (author and testers).

Add a Comment

Login with GitHub to post a comment