? ? Success

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
12 Oct 2014

This fixes all the code styles issues except class doc blocks. We will create independent PRs for them

avatar phproberto phproberto - open - 12 Oct 2014
avatar jissues-bot jissues-bot - change - 12 Oct 2014
Labels Added: ?
avatar dbhurley
dbhurley - comment - 12 Oct 2014

Just on quick review, is this a B/C break since we're changing function name?

avatar phproberto
phproberto - comment - 12 Oct 2014

PHP functions name are case-insensitive as stated in:

php-function-case-insensitive

Extracted from: http://fr.php.net/manual/en/functions.user-defined.php

avatar dbhurley
dbhurley - comment - 12 Oct 2014

:blush: totally my fault for some reason I was thinking it was a problem... Too little sleep. ;)

avatar javigomez javigomez - close - 12 Oct 2014
avatar dbhurley dbhurley - close - 12 Oct 2014
avatar dbhurley dbhurley - change - 12 Oct 2014
Title
[code style] missing changes
[code style] com_wrapper missing changes
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-12 19:00:41
avatar javigomez javigomez - change - 13 Oct 2014
Labels Added: ?

Add a Comment

Login with GitHub to post a comment