RTC Language Change bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
10 Oct 2025

Pull Request for Issue # .

Summary of Changes

Corrects the americanisation of colour

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

color scheme

Expected result AFTER applying this Pull Request

colour scheme

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 10 Oct 2025
avatar brianteeman brianteeman - change - 10 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Oct 2025
Category Administration Language & Strings
avatar richard67 richard67 - test_item - 10 Oct 2025 - Tested successfully
avatar richard67
richard67 - comment - 10 Oct 2025

I have tested this item ✅ successfully on 0607702

Code review.

Change is correct.

While we use American spelling for code names, e.g. variable or method names or keys of language string, the content should be British.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46264.

avatar tecpromotion tecpromotion - test_item - 10 Oct 2025 - Tested successfully
avatar tecpromotion
tecpromotion - comment - 10 Oct 2025

I have tested this item ✅ successfully on 0607702


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46264.

avatar tecpromotion tecpromotion - change - 10 Oct 2025
The description was changed
Status Pending Ready to Commit
Labels Added: Language Change PR-5.4-dev
avatar tecpromotion
tecpromotion - comment - 10 Oct 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46264.

avatar tecpromotion tecpromotion - edited - 10 Oct 2025
avatar muhme muhme - change - 17 Oct 2025
Labels Added: RTC bug
avatar muhme
muhme - comment - 17 Oct 2025

✅ Final check before merge with grep -i '".*color.*"' administrator/language/en-GB/* language/en-GB/* before the PR the changed entries are found, with unpacking the PR full package the remaining places are OK as CSS or plugin-type:

aadministrator/language/en-GB/lib_joomla.ini:JLIB_DATABASE_ERROR_FUNCTION_FAILED="DB function failed with error number %s <br><span style=\"color: red;\">%s</span>"
administrator/language/en-GB/lib_joomla.ini:JLIB_JS_AJAX_ERROR_PARSE="A parse error has occurred while processing the following JSON data:<br><code style=\"color:inherit;white-space:pre-wrap;padding:0;margin:0;border:0;background:inherit;\">%s</code>"
administrator/language/en-GB/plg_fields_color.ini:PLG_FIELDS_COLOR_XML_DESCRIPTION="This plugin lets you create new fields of type 'color' in any extensions where custom fields are supported."
administrator/language/en-GB/plg_fields_color.sys.ini:PLG_FIELDS_COLOR_XML_DESCRIPTION="This plugin lets you create new fields of type 'color' in any extensions where custom fields are supported."
language/en-GB/lib_joomla.ini:JLIB_DATABASE_ERROR_FUNCTION_FAILED="DB function failed with error number %s <br><span style=\"color: red;\">%s</span>"
language/en-GB/lib_joomla.ini:JLIB_JS_AJAX_ERROR_PARSE="A parse error has occurred while processing the following JSON data:<br><code style=\"color:inherit;white-space:pre-wrap;padding:0;margin:0;border:0;background:inherit;\">%s</code>"
avatar muhme muhme - close - 17 Oct 2025
avatar muhme muhme - merge - 17 Oct 2025
avatar muhme muhme - change - 17 Oct 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-10-17 12:18:22
Closed_By muhme
avatar muhme
muhme - comment - 17 Oct 2025

Thank you @brianteeman for your contribution. Thank you @tecpromotion and @richard67 for testing.

Add a Comment

Login with GitHub to post a comment