[#46262] - [6.0.0-rc2] Installation of Sample Data fails on fresh install
- New
- Medium
- Build: 5.3-dev
- # 46262
Steps to reproduce the issue
- Install fresh 6.0.0-rc2
- Try to install Sample Data
Expected result
Sample Data get installed
Actual result
You get an error message:
“There is an error in a sample data plugin. Response is invalid.”
System information (as much as possible)
Local install under Laragon 6.0
Additional comments
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
I can confirm this too on rc3
This should have a release blocker tag
wilsonge
- | Labels |
Added:
Release Blocker
|
||
When I remove these lines, the issue does not happen: https://github.com/joomla/joomla-cms/blob/6.0-dev/libraries/src/Versioning/VersionableModelTrait.php#L283-L289
And that seems to work because in the storeHistory of the same trait, the fields are
@rdeutz Can it be that the mentioned lines are just a leftover after you have followed cyrez's change suggestion and moved that from the getSha1Hash method to the storeHistory method, where all stuff is properly checked and the sha1 hash is recalculated?
If leftover, we simply can remove the mentioned lines.
Confirmed
Caused by #46221 @rdeutz
joomla-cms/libraries/src/Versioning/VersionableModelTrait.php
Line 283 in afa8ceb