RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
8 Oct 2025

Pull Request for Issue #46192 .

Summary of Changes

When mail is disabled on a site the NEW button is not present in the admin privacy request screen.

This PR adds an on screen message using the existing language string

Testing Instructions

Disable mail sending in global config and go the privacy request screen

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
4.00

avatar brianteeman brianteeman - open - 8 Oct 2025
avatar brianteeman brianteeman - change - 8 Oct 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Oct 2025
Category Administration
avatar richard67
richard67 - comment - 8 Oct 2025

@Sulpher Please test this one here as it solves your issue, and when done, go to the PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/46256 and use the blue "Test this" button at the top left corner to select your test result and submit. Thanks in advance.

avatar Sulpher Sulpher - test_item - 9 Oct 2025 - Tested successfully
avatar Sulpher
Sulpher - comment - 9 Oct 2025

I have tested this item ✅ successfully on 6b233c0

Joomla 5.3.4. When Send Mail option is disabled, there is no NEW button in Administrator Panel > Privacy Contests > Requests.
After this PR I see this notification:

Information requests can't be created when sending mail is disabled.

All is clear and informative.
screenshot

alt


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46256.

avatar richard67 richard67 - test_item - 10 Oct 2025 - Tested successfully
avatar richard67
richard67 - comment - 10 Oct 2025

I have tested this item ✅ successfully on 6b233c0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46256.

avatar richard67 richard67 - change - 10 Oct 2025
Status Pending Ready to Commit
Labels Added: bug PR-5.4-dev
avatar richard67
richard67 - comment - 10 Oct 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46256.

avatar muhme muhme - change - 17 Oct 2025
Labels Added: RTC
avatar muhme
muhme - comment - 17 Oct 2025

✅ Final test before merge with JBT & PHP 8.1: No button / no message before and error message seen after applying PR with gh pr checkout 46256

avatar muhme muhme - change - 17 Oct 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-10-17 11:36:23
Closed_By muhme
avatar muhme muhme - close - 17 Oct 2025
avatar muhme muhme - merge - 17 Oct 2025
avatar muhme
muhme - comment - 17 Oct 2025

Thank you @brianteeman for your contribution. Thank you @Sulpher and @richard67 for testing.

Add a Comment

Login with GitHub to post a comment