[#46250] - [5.4] Fix: use UTF-8 safe substr in mod_articles_category
- Pending
- Medium
- Build: 5.3-dev
- # 46250
- Diff
- Suyash2JZ:fix/mod_articles_category-trim-mbstring
User tests: Successful: Unsuccessful:
Fix: use UTF-8 safe substr for multibyte support in mod_articles_category
Fixes #45452
Summary of Changes
Replaced the regular substr() function with mb_substr() in mod_articles_category to ensure correct multibyte string handling for UTF-8 encoded text.
Testing Instructions
- Create or open a Joomla site with multibyte characters (e.g., accented or non-Latin characters) in article titles or categories.
- Display those articles using the "Articles - Category" module.
- Verify that the trimming and display of multibyte titles is now correct.
Actual result BEFORE applying this Pull Request
Multibyte characters were sometimes cut off or displayed incorrectly.
Expected result AFTER applying this Pull Request
Multibyte characters are displayed correctly and not truncated.
Link to documentations
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
@Suyash2JZ Please fix the code style errors, see my previous review suggestions. Thanks in advance.
Update 2025-11-02: I've allowed myself to apply the necessary code style fixes.
| Title |
|
||||||
| Labels |
Added:
bug
PR-5.4-dev
|
||
The code looks OK but I could not figure out how to trigger before/after observations. I tried altering the date filtering options in the module. So testing needs someone with more insight or more specific testing instructions.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46250.
I couldn't figure out how to compare before and after. Looking at the description, it's about multibyte support, but the changes in the code only affect lines that deal with a date field. Okay, the addition in these lines certainly makes sense, but I can't understand where multibyte characters should be cut off incorrectly.
Like the previous fellow campaigner, someone with more experience in this area is definitely needed here. A more detailed description of the testing instructions would be helpful.
I have tested this item 🔴 unsuccessfully on b4aa1cc
Multibyte characters were displayed correctly and not truncated even before applying the PR
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46250.
I have tested this item ✅ successfully on b4aa1cc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46250.
Wrong raporting - please delete !
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46250.
This pull request has been automatically rebased to 5.4-dev.