Feeling Lucky
?
?
[#4625] - [Code Style] Changes in tag standards: Libraries/legacy
- Closed
- 20 Oct 2014
- Medium
- Build: staging
- # 4625
- Diff
- javigomez:change-tags-libraries-legacy
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This pull should fix the issue detailed here: joomla/coding-standards#80
I have broken in parts this original pull #4590 to make it easy for review. This pull is contains only the libraries/legacy changes.
The components/, modules/, ... are going to be sent in different pulls.
jissues-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Code style |
| Labels |
Added:
?
|
||
javigomez
- comment
- 16 Oct 2014
I'm merging current staging that has the change in the sniffers, it should pass travis. Let's see
nicksavov
- comment
- 17 Oct 2014
Doesn't pass yet, unfortunately.
| Labels |
Removed:
?
|
||
javigomez
- comment
- 17 Oct 2014
mmm I see... just fixed the following error:
FILE: ...me/travis/build/joomla/joomla-cms/libraries/compat/jsonserializable.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
15 | ERROR | @link tag comment indented incorrectly; expected 3 spaces but
| | found 5
16 | ERROR | @since tag comment indented incorrectly; expected 2 spaces but
| | found 4
Let's see if travis is now happy ^_^
Bakual
- comment
- 20 Oct 2014
Merged into staging. Thanks!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-20 12:32:36 |
failing