While fixing Code Style issues I found this undefined variable $row at:
components/com_tags/views/tag/view.feed.php on line 74
looks like wrong variable name. See https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/views/tags/view.feed.php#L74
Labels |
Added:
?
|
Why does this not have the PR-staging tag?
Sorry. I deleted the original repo which I made the PR. I think that's the reason :(.
Status | New | ⇒ | Closed |
Rel_Number | ⇒ | 4651 | |
Relation Type | ⇒ | Related to |
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-04 11:04:25 |
Set to "closed" on behalf of @Hackwar by The JTracker Application at issues.joomla.org/joomla-cms/4623
Labels |
Added:
?
Removed: ? |
There are several reasons causing this issue:
The wrong variable name as you said: $row should be replaced by $item
The getListQuery method of TagsModelTags class doesn't return author, author_email, fields, so it will throw warning in other line code as well : https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/views/tags/view.feed.php#L56
The code in this line will also throw warning as there is no displayDate returned for each item https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/views/tags/view.feed.php#L57
I can make a PR to fix these issues (it is quite easy). However, do you know how we can see there warnings (so that I can give testing instructions in the pull require) ? Is there an easy way to show these warnings ?