?
Related to # 4651
Referenced as Pull Request for: # 5552
avatar javigomez
javigomez
12 Oct 2014

While fixing Code Style issues I found this undefined variable $row at:

components/com_tags/views/tag/view.feed.php on line 74

looks like wrong variable name. See https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/views/tags/view.feed.php#L74

avatar javigomez javigomez - open - 12 Oct 2014
avatar joomdonation
joomdonation - comment - 13 Oct 2014

There are several reasons causing this issue:

  1. The wrong variable name as you said: $row should be replaced by $item

  2. The getListQuery method of TagsModelTags class doesn't return author, author_email, fields, so it will throw warning in other line code as well : https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/views/tags/view.feed.php#L56

  3. The code in this line will also throw warning as there is no displayDate returned for each item https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/views/tags/view.feed.php#L57

I can make a PR to fix these issues (it is quite easy). However, do you know how we can see there warnings (so that I can give testing instructions in the pull require) ? Is there an easy way to show these warnings ?

avatar joomdonation
joomdonation - comment - 13 Oct 2014

OK. I went ahead to make pull request to fix this issue #4651 (and several issues I found as well). Please help testing it :)

avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar aDaneInSpain
aDaneInSpain - comment - 17 Oct 2014

Why does this not have the PR-staging tag?

avatar joomdonation
joomdonation - comment - 17 Oct 2014

Sorry. I deleted the original repo which I made the PR. I think that's the reason :(.

avatar Hackwar
Hackwar - comment - 4 Dec 2014

Since we have #4651 to fix this, I'm going to close this issue report.

avatar zero-24 zero-24 - close - 4 Dec 2014
avatar Hackwar Hackwar - change - 4 Dec 2014
Status New Closed
Rel_Number 4651
Relation Type Related to
avatar jissues-bot jissues-bot - change - 4 Dec 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-12-04 11:04:25
avatar jissues-bot jissues-bot - close - 4 Dec 2014
avatar jissues-bot
jissues-bot - comment - 4 Dec 2014

Set to "closed" on behalf of @Hackwar by The JTracker Application at issues.joomla.org/joomla-cms/4623

avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?
Removed: ?

Add a Comment

Login with GitHub to post a comment