Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4621] - [code style] com_media backend

? ? Success

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
12 Oct 2014

This fixes all the issues except the class doc block changes because we will submit independent PRs for that.

avatar phproberto phproberto - open - 12 Oct 2014
avatar jissues-bot jissues-bot - change - 12 Oct 2014
Labels Added: ?
avatar roland-d
roland-d - comment - 12 Oct 2014

@phproberto There are 2 missing changes:
Name
manager.php

Location
file .../administrator/components/com_media/models/manager.php - [joomla-cms]

Problem synopsis

phpcs: No scope modifier specified for function "getFolderList" (at line 63)

phpcs: No scope modifier specified for function "getFolderTree" (at line 125)
avatar phproberto
phproberto - comment - 12 Oct 2014

PR updated to add the since tags and the scope.

Thanks for reviewing it @roland-d

avatar javigomez javigomez - change - 13 Oct 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Oct 2014
Category ⇒ Code style
avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar nicksavov nicksavov - change - 17 Oct 2014
Labels Removed: ?
avatar LLNet LLNet - test_item - 17 Oct 2014 - Tested successfully
avatar LLNet
LLNet - comment - 17 Oct 2014

Looks good :)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4621.

avatar Bakual
Bakual - comment - 20 Oct 2014

Merged into staging. Thanks!

avatar phproberto phproberto - close - 20 Oct 2014
avatar phproberto phproberto - change - 20 Oct 2014
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-10-20 12:26:14

Add a Comment

Login with GitHub to post a comment