User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Updates Sa11y from 4.2.3 to 4.3.1. Biggest change is clickable "Images" panel.
npm resource change
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | NPM Change |
Title |
|
Thanks @adamchaboryk some great improvements
Then release managers still need to decide whether it is not to late for 5.4 RC
It is definitely too late as the 5.4.0-rc1 and 6.0.0-rc1 packages have been built yesterday.
Let me know if you'd like me to resubmit my PR on a different branch!
@adamchaboryk Your PR is not complete as it is missing the changes in the composer.json file.
@brianteeman has created PR #46183 which contains all necessary changes.
Please both agree if to complete this PR here and close the other one, or vic versa.
Rebasing is not urgent right now, it can be done later. It will very likely have to be rebased to the 6.1-dev branch, but wait until that it finally decided. We will let you know here when that is the case.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-09-28 17:16:28 |
Closed_By | ⇒ | adamchaboryk | |
Labels |
Added:
NPM Resource Changed
PR-5.4-dev
|
I'll close my PR, and leave this with @brianteeman. Thank you both!!
Thank you @adamchaboryk for your contribution and your understanding.
Works good, thanks!
Please update also
package.json
.Then release managers still need to decide whether it is not to late for 5.4 RC