NPM Resource Changed PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar adamchaboryk
adamchaboryk
28 Sep 2025

Pull Request for Issue # .

Summary of Changes

Updates Sa11y from 4.2.3 to 4.3.1. Biggest change is clickable "Images" panel.

Testing Instructions

  • Find an article with images
  • Select "Accessibility Check"
  • Open the Images panel.
  • Click on an image within Sa11y's images panel, it should scroll into view.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

npm resource change

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar adamchaboryk adamchaboryk - open - 28 Sep 2025
avatar adamchaboryk adamchaboryk - change - 28 Sep 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2025
Category NPM Change
avatar adamchaboryk adamchaboryk - change - 28 Sep 2025
Title
Update package-lock.json
[5.4] Update Sa11y to 4.3.1
avatar adamchaboryk adamchaboryk - edited - 28 Sep 2025
avatar Fedik
Fedik - comment - 28 Sep 2025

Works good, thanks!

Please update also package.json.
Then release managers still need to decide whether it is not to late for 5.4 RC

avatar brianteeman
brianteeman - comment - 28 Sep 2025

Thanks @adamchaboryk some great improvements

avatar brianteeman
brianteeman - comment - 28 Sep 2025

I did a pull request with the packages.json changes #46183

avatar richard67
richard67 - comment - 28 Sep 2025

Then release managers still need to decide whether it is not to late for 5.4 RC

It is definitely too late as the 5.4.0-rc1 and 6.0.0-rc1 packages have been built yesterday.

avatar adamchaboryk
adamchaboryk - comment - 28 Sep 2025

Let me know if you'd like me to resubmit my PR on a different branch!

avatar richard67
richard67 - comment - 28 Sep 2025

@adamchaboryk Your PR is not complete as it is missing the changes in the composer.json file.

@brianteeman has created PR #46183 which contains all necessary changes.

Please both agree if to complete this PR here and close the other one, or vic versa.

Rebasing is not urgent right now, it can be done later. It will very likely have to be rebased to the 6.1-dev branch, but wait until that it finally decided. We will let you know here when that is the case.

avatar adamchaboryk adamchaboryk - change - 28 Sep 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-09-28 17:16:28
Closed_By adamchaboryk
Labels Added: NPM Resource Changed PR-5.4-dev
avatar adamchaboryk adamchaboryk - close - 28 Sep 2025
avatar adamchaboryk
adamchaboryk - comment - 28 Sep 2025

I'll close my PR, and leave this with @brianteeman. Thank you both!!

avatar richard67
richard67 - comment - 28 Sep 2025

Thank you @adamchaboryk for your contribution and your understanding.

Add a Comment

Login with GitHub to post a comment