Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4617] - [Code Style] Changes in tag standards: Libraries/joomla

? ? Failure

User tests: Successful: Unsuccessful:

avatar javigomez
javigomez
12 Oct 2014

This pull should fix the issue detailed here: joomla/coding-standards#80

I have broken in parts this original pull #4590 to make it easy for review. This pull is contains only the libraries/joomla changes.
The components/, modules/, ... are going to be sent in different pulls.

This pull is related to #4603

Note for reviewer: I was going to break this into several pulls but I found easier to do it in different commints, so you can see the changes per commit at https://github.com/joomla/joomla-cms/pull/4617/commits.

avatar javigomez javigomez - open - 12 Oct 2014
avatar jissues-bot jissues-bot - change - 12 Oct 2014
Labels Added: ?
avatar javigomez javigomez - change - 13 Oct 2014
The description was changed
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Oct 2014
Category ⇒ Code style
avatar nicksavov
nicksavov - comment - 16 Oct 2014

Looks like there are some merge conflicts. Could you update to latest staging?

avatar nicksavov nicksavov - change - 16 Oct 2014
Labels Added: ?
avatar javigomez
javigomez - comment - 16 Oct 2014

Updated ^_^

avatar nicksavov
nicksavov - comment - 16 Oct 2014

Thanks!

avatar nicksavov nicksavov - change - 17 Oct 2014
Labels Removed: ?
avatar javigomez
javigomez - comment - 17 Oct 2014

mmm seems that Travis fails due to the same error as I have fixed in the last update on #4625

I think to avoid conflicts I'm going to wait for #4625 to be merged and then I'll update the present pull.

avatar javigomez javigomez - close - 20 Oct 2014
avatar javigomez javigomez - change - 20 Oct 2014
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-10-20 12:49:28
avatar Bakual
Bakual - comment - 20 Oct 2014

Merged into staging. Thanks!

Add a Comment

Login with GitHub to post a comment