Current Node.js LTS is v22.

@tecpromotion Could you change it to node v22? See previous comment. Thanks in advance.

Honestly it doesn't matter. As long as it is actual, I would leave it on version 24.

@laoneo Not for releases, but could cause problems for local development.

For example, if someone submits a PR for the build scripts, which uses RegExp.escape(...), the tests will pass and the PR will most likely be merged, however if any developers are using Node.js LTS (v22 currently), this code won't work at all, because it was included in V8 13.6, which was shipped with Node.js 24.

It's a major version change, which includes features unsupported in v22.

Just my 2 cents

Ok. I don't think so running the translation workflows on a newer version of node is a problem.

Wouldn't using an STS mean we have to change the version again sooner than it would be the case with an LTS, if we don't want to run with a version which has reached end of support?

I know, it's only the GitHub actions.

But everywhere else we use (or require) LTS.

I think GH actions don't fall under the minimum requirements. But it is fine to change to LTS as well. Just wanted to point out that here it should be fine not using LTS. I see a benefit of using different versions, like that we know it works also on the latest.

We use this GHA ONLY and EXCLUSIVELY in the translation-bot repo! This change has no effect here or in local environments. Or am I overlooking something @HLeithner?
Also see: Breaking changes in V5

This has nothing to do with joomla or it's build process, and can be merged. No idea why it's not merged already.

No idea why it's not merged already.

@HLeithner Because you haven't approved it yet? 😛

Thanks all (author and reviewers).

This has nothing to do with joomla or it's build process, and can be merged. No idea why it's not merged already.

It does run the build script here in node 24 with this pr. So @C-Lodder is right when it is vice versa. It might break, when the build script has a feature, which was removed in 24.

Then someone should make a PR to change to v22.

We definitely have to go to v22 as for a new build of a new PR we now get the same error as @bembelimen recently had when building with node v24:

file:///__w/joomla-cms/joomla-cms/build/build-modules-js/stylesheets/css-versioning.mjs:83
    throw new Error(error);
          ^
Error: Error: ENOENT: no such file or directory, open 'undefined/content.css'
    at fixVersion (file:///__w/joomla-cms/joomla-cms/build/build-modules-js/stylesheets/css-versioning.mjs:83:11)
    at async Promise.all (index 0)

The error is not related to the recent update of css-versioning.mjs, it happened before that when using node v24.

I will make a PR to change to v22 in a few minutes.

@laoneo @HLeithner Please check and approve PR #46169 . Thanks in advance.

Hmm, I do not see the relationship now as this PR only changed it for the translation PR actions.

However, the CI action use node version = latest.

And so that runs with v24 now, too.