RTC Release Blocker NPM Resource Changed PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar LadySolveig
LadySolveig
20 Sep 2025

Pull Request for Issue #.

Summary of Changes

Follow up for PR #46100

Update npm dependency diff.js from 5.2.0 to 8.0.2.

Testing Instructions

Important

This is a NPM update, please use the prebuilt packages or run npm install.

This package is only used in the history compare modal view, to show the differences (red and green background) in text blocks.

  • Open an article.
  • Remove some text and add some text in the article text area.
  • Click the button Versions in the toolbar.
  • Select two versions with article text changes.
image

Actual result BEFORE applying this Pull Request

Should show the difference by marking the deleted text with red background and the added with a green background.

Expected result AFTER applying this Pull Request

Nothing changed - looks the same.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar LadySolveig LadySolveig - open - 20 Sep 2025
avatar LadySolveig LadySolveig - change - 20 Sep 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2025
Category NPM Change
avatar richard67 richard67 - change - 21 Sep 2025
Labels Added: NPM Resource Changed PR-6.0-dev
avatar Bodge-IT Bodge-IT - test_item - 22 Sep 2025 - Tested successfully
avatar Bodge-IT
Bodge-IT - comment - 22 Sep 2025

I have tested this item ✅ successfully on 97f891b

Noted some additional artifacts presented by Diff but update and dependency OK.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46139.

avatar brianteeman
brianteeman - comment - 22 Sep 2025

Noted some additional artifacts presented by Diff but update and dependency OK.

Such as? There really should be no difference at all for it to be a successful test

avatar richard67
richard67 - comment - 22 Sep 2025

Noted some additional artifacts presented by Diff

@Bodge-IT Which artifacts? Do you have some screenshot?

avatar Bodge-IT
Bodge-IT - comment - 22 Sep 2025

Apologies, I checked the comparisons via my screenshots taken but had my images reversed.
Updated diff:
2025-09-21 18_37_13 - Articles_ Edit - testing #46139 - Administration — Mozilla Firefox
Current Diff:
2025-09-21 18_32_30 - Articles_ Edit - testing #46139 - Administration — Mozilla Firefox

avatar brianteeman
brianteeman - comment - 22 Sep 2025

actually looks like you are identifying a problem in the versions update

avatar richard67
richard67 - comment - 22 Sep 2025

Noted some additional artifacts presented by Diff but update and dependency OK.

Such as? There really should be no difference at all for it to be a successful test

@brianteeman There should be differences if bugs were fixed upstream with the new version.

To me @Bodge-IT 's screenshot of the updated diff seems more correct than the one of the current version.

avatar brianteeman brianteeman - test_item - 22 Sep 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 22 Sep 2025

I have tested this item ✅ successfully on 97f891b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46139.

avatar richard67 richard67 - change - 22 Sep 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Sep 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46139.

avatar softforge softforge - change - 23 Sep 2025
Labels Added: RTC Release Blocker
avatar softforge softforge - change - 23 Sep 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-09-23 09:02:13
Closed_By softforge
avatar softforge softforge - close - 23 Sep 2025
avatar softforge softforge - merge - 23 Sep 2025
avatar softforge
softforge - comment - 23 Sep 2025

Thank you @LadySolveig and all who tested

Add a Comment

Login with GitHub to post a comment