[#46137] - [5.4] PHP8.5 deprecated code
- Fixed in Code Base
- 15 Oct 2025
- Medium
- Build: 5.4-dev
- # 46137
- Diff
- dgrammatiko:patch-5
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Better variable handling to eliminate the deprecation warnings on PHP 8.5
Deprecated: Using null as an array offset is deprecated, use an empty string instead in xxx/libraries/src/HTML/Helpers/Select.php on line 495
Testing Instructions
Open the local url administrator/index.php?option=com_menus&view=item&client_id=0&layout=edit&id=101 and check the right sidebar for deprecations (PHP8.5 required and error reporting to max)
Actual result BEFORE applying this Pull Request
Deprecations logged
Expected result AFTER applying this Pull Request
No deprecations
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
@richard67 Yes. Will look at it and test it later today
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 7b5fbde
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46137.
I have tested this item ✅ successfully on 7b5fbde
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46137.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46137.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Pending |
Back to pending as the PR has received changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46137.
@joomdonation @brianteeman Could you test again? The PR has received some changes. Thanks in advance.
@heelc29 @richard67 The latest changes are not needed. $options['option.attr'], $options['option.id'].... are initialized with it default value by this array https://github.com/joomla/joomla-cms/blob/5.4-dev/libraries/src/HTML/Helpers/Select.php#L34-L47, so using isset as in the last changes is not necessary at all. I would revert the last changes and set the PR back to RTC again
| Labels |
Removed:
RTC
|
||
@joomdonation Could you give it a quick retest just to be sure before we set RTC again? Thanks in advance.
| Status | Pending | ⇒ | Ready to Commit |
Tested it again and it is working. So I set this back to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46137.
| Labels |
Added:
RTC
bug
|
||
Final test before merge using JBT php8.5-rc
- Seen 4 Deprecated messages from two different line numbers before PR on
'administrator/index.php?option=com_menus&view=item&client_id=0&layout=edit&id=101s' - Graft PR's full packge
- ✅ no Deprecated anymore, not in any tab, opening menu item, creating new, trashing, filtering and deleting menu item is still working
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-10-15 14:54:48 |
| Closed_By | ⇒ | muhme |
Thank you @dgrammatiko for your contribution. Thank you @joomdonation and @heelc29 for supporting. Thank you @brianteeman, @heelc29 and @joomdonation for testing.
@joomdonation As you have tested the other 2 PRs of the same kind: Could you also test this one? Thanks in advance.