User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Follow up PR for #45875 .
This pull request (PR) updates the lists of files and folders to be deleted on update in script.php to the changes from PR #45875 so that the files and folders related to any "What's New" guided tours for 5.x versions will be removed when updating from 5.4 to 6.x.
Folder /media/com_guidedtours/images
is not added to the list of folder to be deleted. It might be removed now, but it will be needed again when PR #45967 will be merged.
In addition it removed an exclusion for the language files of the "What's New in 5.4" guided tour in the build/deleted_file_check.php
script which is used to check for deleted files and folders.
Code review. Check PR #45875 for deleted files and folders and verify that it matches the files and folder being added by this PR to the list.
Or alternatively, if you want to make a real test: Update a 5.4.0-beta3 to the patched package for PR #45875 for the actual result, and update a 5.4.0-beta3 to the patched package for this PR here for the expected result.
The files and folder added by this PR to the list are still there after an update from 5.4.0-beta3.
The files and folder added by this PR to the list are deleted after an update from 5.4.0-beta3, except of folder /media/com_guidedtours/images
, which might be empty now but will be needed for sure when PR #45967 with the "What's New in Joomla 6.0" tour has been merged.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_admin Repository |
Labels |
Added:
PR-6.0-dev
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-09-17 07:13:43 |
Closed_By | ⇒ | Bodge-IT |
I have tested this item ✅ successfully on d49da9a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46112.