[#46081] - [5.3] Generate unique alias on “Save as Copy” for Smart Search filters
- Pending
- Medium
- Build: 5.3-dev
- # 46081
- Diff
- travisrisner:5.3-search-filter-copy-bug
User tests: Successful: Unsuccessful:
Pull Request for Issue #43969 .
Summary of Changes
Ensures that a unique alias is generated whenever com_finder search filters are duplicated when using the Save as Copy feature.
Testing Instructions
- Administrator → Components → Smart Search → Filters
- Create a filter named My Filter and click Save.
- Click Save as Copy and repeat multiple times.
Actual result BEFORE applying this Pull Request
- Error:
Save failed with the following error: Another Filter has the same alias.
Expected result AFTER applying this Pull Request
- Copies save successfully with incremented aliases (e.g.,
my-filter-2,my-filter-3, …).
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
| Labels |
Added:
bug
PR-5.3-dev
|
||
I have tested this item ✅ successfully on 8d08537
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46081.
I have tested this item ✅ successfully on 8d08537
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46081.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46081.
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to requested changes (use prepared statements).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46081.
| Labels |
Added:
Updates Requested
|
||
@ceford @brianteeman @dautrich Could one of you guys test this PR again with the latest changes? That would be great. One test if it still works is sufficient..
Actually, I think there is a problem! Saving with the patch applied does work. But the list of filters has duplicate titles and there is no way to tell which is which. I seem to remember that other duplicates add the instance number to the title.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46081.
No it adds the number to the alias
maybe we need to display the alias in the list view?
I have tested this item ✅ successfully on 95a2471
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46081.