Feeling Lucky
RTC
bug
PR-5.3-dev
[#46078] - [5.3] Enhance header handling in transport classes to support array values
- Fixed in Code Base
- 20 Sep 2025
- Medium
- Build: 5.3-dev
- # 46078
- Diff
- LadySolveig:5.3/patch/http-headers-array
User tests: Successful: Unsuccessful:
Summary of Changes
@LadySolveig found and fixed an issue (thanks for that) with the HTTP-classes header handling, as they could be arrays.
As the underlying library laminas-diactotos gives us an array from the getHeaders function in the request, we also need to support this.
/**
* {@inheritdoc}
*/
public function getHeaders(): array
{
$headers = $this->headers;
if (
! $this->hasHeader('host')
&& $this->uri->getHost()
) {
$headers['Host'] = [$this->getHostFromUri()];
}
return $headers;
}Same way at it is done and fixed in the Joomla! http Framework Package.
- https://github.com/joomla-framework/http/blob/a06323db9d0a55fa0f63236f14d3e3d767c7fb0c/src/Transport/Curl.php#L99
- https://github.com/joomla-framework/http/blob/a06323db9d0a55fa0f63236f14d3e3d767c7fb0c/src/Transport/Socket.php#L112
- https://github.com/joomla-framework/http/blob/a06323db9d0a55fa0f63236f14d3e3d767c7fb0c/src/Transport/Stream.php#L118
Testing instructions
Hard to test, it's streamlining the code, so I guess all the requests using the HTTP-class, like the stats collection, should still work.
@Hackwar as you implemented this in the framework, could you have a look and see if it's correct? Thanks!
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.3-dev
|
||
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-09-20 14:59:01 |
| Closed_By | ⇒ | LadySolveig |
LadySolveig
- comment
- 20 Sep 2025
Thanks to all involved 💚
RTC after 2 successful review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46078.