User tests: Successful: Unsuccessful:
The "list of fields" menu item of com_fields for custom backend menus was using the wrong request parameter. That prevented ACL checks from running, resulting in the fact that a menu item could be created but was never shown.
Furthermore, the context name wasn't correctly set. In example instead of "com_content.article" (singular!) "com_content.articles" (plural) was used, as the context name was derived from the human readable label.
Menu item is not shown
Menu item is shown, Field is shown
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_fields |
Labels |
Added:
PR-5.4-dev
|
@richard67 remaining lifetime of the branch, however i'm also fine with rebasing
@SniperSister No, it's ok. Just wanted to know if there is some other reason.
@SniperSister - I either didn't understand your testing instructions or something is not 100% working - can't replicate the BEFORE issue and the AFTER situation is the same as in the BEFORE position. ( I apologize if I messed something up).
I have tested this item 🔴 unsuccessfully on 6aeab52
@brianteeman have you updated the menu item after applying the patch? Otherwise the invalid request parameters remain stored in the DB and the menu item will not be shown.
I have tested this item ✅ successfully on 6aeab52
Had to recreate the menu after the pr
Otherwise the invalid request parameters remain stored in the DB and the menu item will not be shown.
Would it be possible to fix that on update with a fancy SQL update? (If yes we can do that with a separate PR).
Would it be possible to fix that on update with a fancy SQL update? (If yes we can do that with a separate PR).
It would be possible yes - on the other hand: these items would have never shown up in the past, so I sort of question if anyone has actually used those items in real world because i haven't seen any issues raised about it. So: probably not worth the effort.
You could have the menu item from a preset but that worked as the presets have the link hard coded.
There is another bug with the preset but I will submit a pr shortly for that.
these items would have never shown up in the past
I see. So better no fix in update for these. People could report it as bug if these items suddenly appear.
I have tested this item ✅ successfully on 6aeab52
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
RTC
bug
|
Final test before merge with JBT graft:
administrator/logs/*
including PHP logStatus | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-09-11 08:02:10 |
Closed_By | ⇒ | muhme |
Thank you @SniperSister for your contribution. Thank you @brianteeman, @richard67 and @exlemor for testing.
@SniperSister Any reason why not to fix it in 5.3-dev?