RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
9 Sep 2025

Summary of Changes

The "list of fields" menu item of com_fields for custom backend menus was using the wrong request parameter. That prevented ACL checks from running, resulting in the fact that a menu item could be created but was never shown.

Furthermore, the context name wasn't correctly set. In example instead of "com_content.article" (singular!) "com_content.articles" (plural) was used, as the context name was derived from the human readable label.

Testing Instructions

  • Create a custom field for articles
  • Create a custom backend menu
  • Create a "List all Fields" menu item for com_fields in that backend menu, select "Articles - Articles" as context
  • Test BEFORE condition
  • Apply patch
  • Open the menu item settings, re-select "Articles - Articles"
  • Save
  • Test AFTER condition

Actual result BEFORE applying this Pull Request

Menu item is not shown

Expected result AFTER applying this Pull Request

Menu item is shown, Field is shown

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar SniperSister SniperSister - open - 9 Sep 2025
avatar SniperSister SniperSister - change - 9 Sep 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Sep 2025
Category Administration com_fields
avatar SniperSister SniperSister - change - 9 Sep 2025
Labels Added: PR-5.4-dev
avatar SniperSister SniperSister - change - 9 Sep 2025
The description was changed
avatar SniperSister SniperSister - edited - 9 Sep 2025
avatar richard67
richard67 - comment - 9 Sep 2025

@SniperSister Any reason why not to fix it in 5.3-dev?

avatar SniperSister
SniperSister - comment - 9 Sep 2025

@richard67 remaining lifetime of the branch, however i'm also fine with rebasing

avatar richard67
richard67 - comment - 9 Sep 2025

@SniperSister No, it's ok. Just wanted to know if there is some other reason.

avatar exlemor
exlemor - comment - 10 Sep 2025

@SniperSister - I either didn't understand your testing instructions or something is not 100% working - can't replicate the BEFORE issue and the AFTER situation is the same as in the BEFORE position. ( I apologize if I messed something up).

avatar SniperSister
SniperSister - comment - 10 Sep 2025

@exlemor If you create a custom backend menu item of type "List all Fields" for articles fields, that field is shown in the custom admin menu (so in the menu sidebar, not the management list view!)?

avatar brianteeman
brianteeman - comment - 10 Sep 2025

Tested and can confirm the bug but after applying the PR the menu is still not displayed

image
avatar brianteeman brianteeman - test_item - 10 Sep 2025 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 10 Sep 2025

I have tested this item 🔴 unsuccessfully on 6aeab52


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46052.

avatar SniperSister
SniperSister - comment - 10 Sep 2025

@brianteeman have you updated the menu item after applying the patch? Otherwise the invalid request parameters remain stored in the DB and the menu item will not be shown.

avatar brianteeman brianteeman - test_item - 10 Sep 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 10 Sep 2025

I have tested this item ✅ successfully on 6aeab52


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46052.

avatar brianteeman
brianteeman - comment - 10 Sep 2025

Had to recreate the menu after the pr


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46052.

avatar richard67
richard67 - comment - 10 Sep 2025

Otherwise the invalid request parameters remain stored in the DB and the menu item will not be shown.

Would it be possible to fix that on update with a fancy SQL update? (If yes we can do that with a separate PR).

avatar SniperSister
SniperSister - comment - 10 Sep 2025

Would it be possible to fix that on update with a fancy SQL update? (If yes we can do that with a separate PR).

It would be possible yes - on the other hand: these items would have never shown up in the past, so I sort of question if anyone has actually used those items in real world because i haven't seen any issues raised about it. So: probably not worth the effort.

avatar brianteeman
brianteeman - comment - 10 Sep 2025

You could have the menu item from a preset but that worked as the presets have the link hard coded.

There is another bug with the preset but I will submit a pr shortly for that.

avatar richard67
richard67 - comment - 10 Sep 2025

these items would have never shown up in the past

I see. So better no fix in update for these. People could report it as bug if these items suddenly appear.

avatar richard67 richard67 - test_item - 10 Sep 2025 - Tested successfully
avatar richard67
richard67 - comment - 10 Sep 2025

I have tested this item ✅ successfully on 6aeab52


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46052.

avatar richard67 richard67 - change - 10 Sep 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 10 Sep 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46052.

avatar muhme muhme - change - 11 Sep 2025
Labels Added: RTC bug
avatar muhme
muhme - comment - 11 Sep 2025

Final test before merge with JBT graft:

  • Problem seen with nightly build (added a second menu item to ensure the menu is shown)
  • ✅ Fix seen with PRs full package and additionally tested that the list of all fields also works for users
  • ⚠️ Additional tested 'List All Field Groups' failed for articles and users, menu entries are not shown -> created #46069
  • ✅ Checked administrator/logs/* including PHP log
avatar muhme muhme - change - 11 Sep 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-09-11 08:02:10
Closed_By muhme
avatar muhme muhme - close - 11 Sep 2025
avatar muhme muhme - merge - 11 Sep 2025
avatar muhme
muhme - comment - 11 Sep 2025

Thank you @SniperSister for your contribution. Thank you @brianteeman, @richard67 and @exlemor for testing.

Add a Comment

Login with GitHub to post a comment