have you got the before and after the wrong way around?

@brianteeman good catch. Lesson learned: FIRST coffee, THEN code.

I have tested this item ✅ successfully on 8d16414

From what I see, the change here is not enough yet. You would need to do the same with how we handle mail template language in User - Joomla plugin https://github.com/joomla/joomla-cms/blob/5.4-dev/plugins/user/joomla/src/Extension/Joomla.php#L216-L228

My quick test with current code:

• Site is in English language
• Configure two users receive email with Backend Language set to German

Result:

• Only first user receives email in German
• The second user (and everyone after that) still receive email in English

@tecpromotion Could you test again and in addition test also the scenario described in @joomdonation 's comment #46050 (comment) ? Thanks in advance.

@SniperSister Now PHPStan complains about direct access to the $language property of the Factory class. Could you change that? If it is not possible or reasonable to change it, you have to update the phpstan-baseline.neon file with ./libraries/vendor/bin/phpstan -b to add exclusions for these cases.

I have tested this item ✅ successfully on 6c08ecf

I have tested this with several languages.
For the German language, we have a total of 5 language packs:

• de-de
• de-at
• de-ch
• de-li
• de-lu

I then changed the subject line in the emails and received different emails.

Done @richard67

Done @richard67

@SniperSister Where?

Here.

I've restored the previous human test result in the issue tracker as the commits which have invalidated the test count were just a change of the phpstan baseline file and code style.

@tecpromotion Sorry to bother you again. Could you test again after the last changes? That would be really great. Thanks in advance, and thanks for previous tests.

I have tested this item ✅ successfully on 8220078

I have tested this item 🔴 unsuccessfully on 8220078

Tested with public available site

• With Nightly Build
  • No problem with second user with German as backend language > Email is sent in German
  • Problem reproduced with setting Administrator default language as German > Email sent in English
• With PRs full package, 'Debug System' and 'Log Almost Everything' enabled
  • Setting Administrator default lanaguage as German > Backend is German
  • ❌ Enabled Automated Updates > Email sent in English: 'Your site has been successfully automatically updated from 5.4.0-beta3-dev+pr.46050 to 5.4.115.'
    • Only one superuser admin from installation, no PHP error log entries, Joomla log entries as usually

Could someone else please retest with setting Administrator default language as e.g. German?

Hmm, seems there are more changes needed. @muhme Could you please try to replace the file administrator/components/com_joomlaupdate/src/Model/NotificationModel.php on your Joomla installation with the attached file to see if it works?

NotificationModel.php

@muhme Could you please try to replace the file
I can, but it would need some hours, I am on the way

I have tested this item ✅ successfully on 8220078

❌ Enabled Automated Updates > Email sent in English: 'Your site has been successfully automatically updated from 5.4.0-beta3-dev+pr.46050 to 5.4.115.'

@muhme you can't test the PR like this. The 5.4.115 does not include the fix and therefore it will fall back to the EN mail. See test instrucitons.

@SniperSister Can it be tested by using the first code snippet from the testing instructions of PR #45721 to trigger the notification mail?

@richard67 the code snippet, an API call, or reaching out to me - whatever works :)

@SniperSister Can it be tested by using the first code snippet from the testing instructions of PR #45721 to trigger the notification mail?

I also used that instructions for testing.

I also used that instructions for testing.

Admin Application and API application differ in setup, might be worth to actually trigger the notification via curl instead to make sure the app context does not influence the result:

--header 'X-JUpdate-Token: YOUR_UPDATE_TOKEN'```

I also used that instructions for testing.

Admin Application and API application differ in setup, might be worth to actually trigger the notification via curl instead to make sure the app context does not influence the result:

curl --location --request POST 'http//YOUR_SITE/api/index.php/v1/joomlaupdate/notificationSuccess' --header 'X-JUpdate-Token: YOUR_UPDATE_TOKEN'

It really depends on the active language of the current running application. The issue will happen if:

• The user language is the same with the language of the current running application
• And the backend language is different

I do not understand how the auto update trigger that email yet but I can see the potential issue by reading logic the code. But if no one else see the issue, you can ignore it.

I have not tested this item.

It really depends on the active language of the current running application. The issue will happen if:

• The user language is the same with the language of the current running application
• And the backend language is different

I do not understand how the auto update trigger that email yet but I can see the potential issue by reading logic the code. But if no one else see the issue, you can ignore it.

I have expanded my test scenario.

I now have six differently configured users.
The starting point is an English backend
One user now uses the backend default language and also receives the email in English.
One user has explicitly set English as the backend language and also receives the email in English.
One user has de-DE as their language and receives the email in German (de-de).
One user has de-AT as their language and receives the email in German (de-at).
One user has de-CH as their language and receives the email in German (de-ch).

@joomdonation which case is not covered and can be tested by me?

@tecpromotion Please try with the case :

• Backend set to German
• Only one active super user account
• That user account has backend language set to English

I'm unsure if you can re-procedure the issue because as I said, I test it by calling the code to send notification directly as described in #45721 (So I logged in using the super user account to trigger the code, mean the active application at that time running on English)

@tecpromotion Please try with the case :

• Backend set to German
• Only one active super user account
• That user account has backend language set to English

I'm unsure if you can re-procedure the issue because as I said, I test it by calling the code to send notification directly as described in #45721 (So I logged in using the super user account to trigger the code, mean the active application at that time running on English)

• Backend set to German
• Only one active super user account
• That user account has backend language set to English

Result: The email is in German (default backend language), but the only user has English as the backend language in their profile.

thx @joomdonation

@joomdonation Could you give it a final test and submit a test result?

@tecpromotion Could you submit a test result? I assume you have already tested with the latest change.

I have tested this item ✅ successfully on b3393a4

If you also want the versions to be displayed in the update email, you can use this command.

curl --location --request POST 'https://YOUR_SITE/api/index.php/v1/joomlaupdate/notificationSuccess' \
--data '{"toVersion":"5.4.115","fromVersion":"5.4.105"}' \
--header 'X-JUpdate-Token: YOUR_UPDATE_TOKEN'

I have tested this item ✅ successfully on b3393a4

The final test has now worked with several variants in the language pack configuration.

Thanks @joomdonation and everyone else.

RTC

RTC

Final test before merge with manual installation in public available site

• With Nightly Build
  • The test instruction was slightly modified to cause a failed update and prevent the PR from being overinstalled. The apache user has been denied write permission for files: chown -R root:root public_html
  • Problem reproduced with setting Administrator default language as German > Email sent in English
• With PRs full package
  • Setting Administrator default language as German > Backend is German
    • ✅ Enabled Automated Updates > Automated Update failed email is sent in German
  • Disabled Automated Updates, created users (system-emails enabled, Super Users group) heiko with explicit German set as backend language and gary with backend language explicit set to English and enabled Automated Updates
    • ✅ The email about the failed Automated Update is sent to admin and heiko in German, and in English to gary
  • Disabled Automated Updates, Created system-emails enabled users richard (default backend language) and phil (explicit set backend language to English), created group 'update-to-be-informed' with the two users and configured 'update-to-be-informed' group and enabled Automated Updates
    • ✅ The email about the failed Automated Update is sent to richard in German, and in English to phil

Thank you @SniperSister for your contribution. Thank you @brianteeman, @joomdonation and @richard67 for supporting. Thank you @joomdonation and @tecpromotion for testing.

I made PR #46071 to clean up/improve code further. As you are familiar with update notification email, it would be great if you can help testing it @tecpromotion, @muhme. Thanks !