User tests: Successful: Unsuccessful:
Improvement of #45624 adding the idea of #45539
Apply the patch by doing a fresh install or an update. You should have now a new Style available to activate.
Press the star to activate it and test that the template works like in #45624 described.
Working child template available
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql Repository NPM Change Installation Language & Strings Libraries Front End Templates (site) |
Also is it really a good example of a child template? Typically a child template would use the root php files of the the parent template and its only the style params that change together with the addition of any template overrides. This child template replaces the root php files of the template which is not something a regular user can do with the ui when creating a child template
Doesnt this need an update sql to remove the extra params from the main cassiopeia template. I am aware that on a clean install they are not stored but if you have enabled either the advanced font or advanced color settings then the params are stored
Also is it really a good example of a child template? Typically a child template would use the root php files of the the parent template and its only the style params that change together with the addition of any template overrides. This child template replaces the root php files of the template which is not something a regular user can do with the ui when creating a child template
The power of child template is, that you can override any template file you need and are not restricted to the html folder. But if you still like something, you can let Joomla! use the parent template solution.
Doesnt this need an update sql to remove the extra params from the main cassiopeia template. I am aware that on a clean install they are not stored but if you have enabled either the advanced font or advanced color settings then the params are stored
The parameters were implemented in J!6, so they shouldn't be in a live system (yet). But if someone updates over the beta, the parameters are in the DB but are ignored, as they're not used in the main template.
Labels |
Added:
Language Change
NPM Resource Changed
PR-6.0-dev
|
I dont understand the reasoning of this change and restricting the new features to a child template. I understand the benefit of having a child template in core and that this child is showcasing the new advanced features. I just dont see the benefit of removing those advanced features from the base template style. Maybe I am missing something?
The power of child template is, that you can override any template file you need and are not restricted to the html folder. But if you still like something, you can let Joomla! use the parent template solution.
Is it even really a child template now
Title |
|
I applied the PR and ran the update sql
There is no template style created. I think you are missing an sql statement in the update sql to create the style
I applied the PR and ran the update sql
There is no template style created. I think you are missing an sql statement in the update sql to create the style
Thanks, didn't commit the last change. Fixed it now.
If you already have a child template called extended then you have a problem on update
The first sql to insert an extensions will fail (as intended) but the second one to insert a style will pass as there is no check and you end up with two styles called cassiopeia extended but with different options
Not really sure what to suggest to ensure the child template can be successfully installed into both db tables. Perhaps give it a more random name and take advantage of the language strings to be more meaningful
When you create a child template the entry in the extensions table contains data in the manifest_cache column. The sql in this PR does not create anything.
There was a discussion elsewhere about the purpose of this field and if it even did anything but in absence of any changes then the sql in this pr should also create the manifest cache.
I dont understand the reasoning of this change and restricting the new features to a child template. I understand the benefit of having a child template in core and that this child is showcasing the new advanced features. I just dont see the benefit of removing those advanced features from the base template style. Maybe I am missing something?