Feeling Lucky
?
?
[#4603] - [Code Style] Changes in tag standards: Libraries/cms
- Closed
- 20 Oct 2014
- Medium
- Build: staging
- # 4603
- Diff
- javigomez:change-tags-libraries-cms
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This pull should fix the issue detailed here: joomla/coding-standards#80
I have broken in parts this original pull #4590 to make it easy for review. This pull is contains only the libraries/cms changes.
The components/, modules/, ... are going to be sent in different pulls.
jissues-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Code style |
| Labels |
Added:
?
|
||
nicksavov
- comment
- 17 Oct 2014
Looks like travis is passing.
| Labels |
Removed:
?
|
||
LLNet
- comment
- 17 Oct 2014
look good :)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4603.
Bakual
- comment
- 20 Oct 2014
Merged into staging. Thanks!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-20 12:38:05 |
We need to modify travis to allow that. Actually is failing because it's verifying that @package is on the class definition.
So we should probably do the reverse thing. Make package not required and maybe add a message when a class includes it.
@mbabker thoughts?