[#45964] - [5.4] Skip version infos for potential downgrades in TUF
- Fixed in Code Base
- 23 Aug 2025
- Medium
- Build: 5.4-dev
- # 45964
- Diff
- SniperSister:5.4-skip-tuf-downgrade-info
User tests: Successful: Unsuccessful:
Pull Request for Issue #45954 #45953
Summary of Changes
This PR fixes an edge case scenario:
So far, the code that is handling potential TUF updates was checking if the currently processed update information would offer an update that's newer than the previously processed update. However, for the very first offered updated, there was no compare target and therefore it was always considered as potential candidate.
That caused issues with the "special update" to 5.1.2 that's currently included in the 6.x branch in the TUF repo to handle a bug in the early 5.1.0 and 5.1.1 releases.
Testing Instructions
- Install Joomla 5.4.0-beta1
- Switch to the "Next" update channel and select beta as stability
- Fetch update information
- Apply patch
- Repeat
Actual result BEFORE applying this Pull Request
- Joomla 6.0.0 beta 1 discovered, but minimum PHP version of 8.1 shown as requirement - because that's the min version of the 5.1.2 release:
Expected result AFTER applying this Pull Request
- Min PHP version of 8.3 shown
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item 🔴 unsuccessfully on 77c1e5c
PHP 8.1.0 still showing after that patch was applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.
I have tested this item 🔴 unsuccessfully on 77c1e5c
Still min PHP version of 8.1 shown as requirement
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.
You all know that you have to search again for updates after having applied the patch? The version will not change by only applying the patch.
You all know that you have to search again for updates after having applied the patch? The version will not change by only applying the patch.
Yes, that's what I did, but PHP 8.1 is still being displayed as minimum requirement.
I have tested this item 🔴 unsuccessfully on 77c1e5c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.
| Labels |
Added:
PBF
bug
PR-5.4-dev
|
||
@brianteeman @exlemor @cybersalt @crimle thanks for testing, I was able to find the root cause if the issue and fix it - please have another look
I have tested this item ✅ successfully on f88b78e
Hi @SniperSister, yes indeed you found the issue ;) I have tested this successfully! :) Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.
I have tested this item ✅ successfully on f88b78e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.
| Labels |
Added:
RTC
|
||
✅ Final test before merge, with JBT graft and the needed MariaDB 10.6 update (which was not required before this PR) 👍
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-23 13:32:01 |
| Closed_By | ⇒ | muhme |
Thank you @SniperSister for your contribution. Thank you @exlemor, @cybersalt, @crimle and @brianteeman for testing.
I have tested this item 🔴 unsuccessfully on 77c1e5c
I have tested this from 2 installations and were unsuccessful in both (Rochen test site and my own hosting).
Sorry ;( @SniperSister) followed your instructions and had another PBF tester watching.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45964.