bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
19 Aug 2025

This reverts commit f1906ba from merged PR #45702 .

Summary of Changes

As can be seen in #45938 PR #45702 introduced a b/c breaking change that should not happen in a minor release.

Testing Instructions

Open a guided tour or guided tour step for editing and go to the publishing tab

Actual result BEFORE applying this Pull Request

The tab contains no fields

Expected result AFTER applying this Pull Request

The tab contains publishing related fields

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 19 Aug 2025
avatar brianteeman brianteeman - change - 19 Aug 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Aug 2025
Category Administration com_menus Front End com_contact com_content com_newsfeeds Layout Libraries
avatar exlemor exlemor - test_item - 20 Aug 2025 - Tested successfully
avatar exlemor
exlemor - comment - 20 Aug 2025

I have tested this item ✅ successfully on c714046

I have successfully tested this. Nice find (and fix) @brianteeman!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45940.

avatar heelc29
heelc29 - comment - 20 Aug 2025

Please also check the alternative PR #45949 to fix the introduced b/c break instead of complete revert.

avatar laoneo
laoneo - comment - 21 Aug 2025

This one here should be closed as it reintroduces deprecated code usage.

avatar chmst chmst - change - 21 Aug 2025
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2025-08-21 07:55:20
Closed_By chmst
Labels Added: PR-5.4-dev
avatar chmst chmst - close - 21 Aug 2025
avatar chmst
chmst - comment - 21 Aug 2025

Maintainers decided to not revert the whole PR but to fix it correctly. Please test #45949

avatar richard67 richard67 - change - 26 Aug 2025
Status Closed New
Closed_Date 2025-08-21 07:55:20
Closed_By chmst
avatar richard67 richard67 - change - 26 Aug 2025
Status New Pending
avatar richard67 richard67 - reopen - 26 Aug 2025
avatar brianteeman
brianteeman - comment - 26 Aug 2025

I have made the requested changes - not sure why they were needed as it was a pure revert

avatar richard67 richard67 - change - 26 Aug 2025
The description was changed
avatar richard67 richard67 - edited - 26 Aug 2025
avatar richard67
richard67 - comment - 26 Aug 2025

I have made the requested changes - not sure why they were needed as it was a pure revert

@brianteeman I don't see the requested changes here on GitHub. They are not needed for the complete revert of the PR, but it would be nice to keep the code style fixes from that PR.

avatar brianteeman brianteeman - change - 26 Aug 2025
Labels Added: bug
avatar brianteeman
brianteeman - comment - 26 Aug 2025

sorry I pressed the wrong button

avatar richard67 richard67 - alter_testresult - 27 Aug 2025 - exlemor: Tested successfully
avatar richard67
richard67 - comment - 27 Aug 2025

I've restored the previous test result from @exlemor 's test as the counter has only been invalidated due to closing the PR and clean branch updates. The code has not really changed.

Add a Comment

Login with GitHub to post a comment