NPM Resource Changed PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar drmenzelit
drmenzelit
17 Aug 2025

Summary of Changes

With #45922 the standard view of mod_menu was refactored.
This PR adds some CSS in Cassiopeia to display the menu correctly.

Testing Instructions

Create different menu items, create a menu module with default layout, test it in different positions.

Actual result BEFORE applying this Pull Request

When the menu is in the position "menu" the submenu makes a shift: #45922 (comment)

Expected result AFTER applying this Pull Request

The submenu opens correctly: #45922 (comment)

There is still a problem with focus-visible on the button (off center), but I haven't a good solution by now (we have the same problem also in Metismenu)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar drmenzelit drmenzelit - open - 17 Aug 2025
avatar drmenzelit drmenzelit - change - 17 Aug 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2025
Category Repository NPM Change
avatar brianteeman brianteeman - test_item - 17 Aug 2025 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Aug 2025

I have tested this item ✅ successfully on cb16b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930.

avatar drmenzelit drmenzelit - change - 17 Aug 2025
Labels Added: NPM Resource Changed PR-6.0-dev
avatar drmenzelit
drmenzelit - comment - 17 Aug 2025

Sorry @brianteeman , can you please test again? It was something wrong with the link color on menus on the sidebar and with the color of the focus-visible

avatar brianteeman
brianteeman - comment - 17 Aug 2025

I'm wondering if this should not be in the mod_menu css

avatar LadySolveig
LadySolveig - comment - 17 Aug 2025

It could well be that the accent colour is set globally.
I don't want to dictate to anyone how the focus colour should be set. I still think that ultimately it depends very much on the template.

But that's just my opinion.

avatar LadySolveig LadySolveig - test_item - 17 Aug 2025 - Tested successfully
avatar LadySolveig
LadySolveig - comment - 17 Aug 2025

I have tested this item ✅ successfully on e15a50c

Thank you very much for your quick support! 💚


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930.
avatar exlemor
exlemor - comment - 18 Aug 2025

@drmenzelit @LadySolveig

I fear/feel that I have may found a bug in PR #45930, (or IF outside of the PR scope, still something that I think should be checked)?

When I put the Default Menu in many positions as requested, I found that when it is in below-top position on CASSIOPEIA, I got a bleed through due to an incorrectly or unset z-index...

ScreenFloat Shot of Safari on 2025-08-18 at 14-03-55

FYI, (while this may not be HOW you want it fixed, if I add z-index:1 (or higher) to .mod-list li .mod-menu__sub in template.min.css, the issue is resolved... )

avatar LadySolveig
LadySolveig - comment - 18 Aug 2025

I found another unintended behaviour with the position that @exlemor tested.
However, as this also affects the Metis menu, I will open a new PR for it.
grafik
Could you please test again. @exlemor

avatar exlemor
exlemor - comment - 18 Aug 2025

I found another unintended behaviour with the position that @exlemor tested. However, as this also affects the Metis menu, I will open a new PR for it. grafik Could you please test again. @exlemor

yes gladly and you beat me to it, I was going to write about the grey focus/active glitch ;)

avatar ChristineWk
ChristineWk - comment - 18 Aug 2025

I can confirm result from Lady Solveig.

Not part of the PR, but FYI:
Version: 6.0.0-alpha4-dev has problems after loaded extensions. Message:
0 Cannot access protected property Joomla\CMS\Application\AdministratorApplication::$input
With Version: 6.0.0-alpha3-dev (a colleague's) doesn't have this problem.

I've now installed 6.0.0-alpha4-dev+pr.45930.
Sorry if I can't help more.
Menus look like this:
Screenshot 2025-08-18 221626

avatar exlemor exlemor - test_item - 18 Aug 2025 - Tested successfully
avatar exlemor
exlemor - comment - 18 Aug 2025

I have tested this item ✅ successfully on d4f176a

I have tested successfully the issue/fix of this PR. Thanks @drmenzelit (@LadySolveig and @brianteeman)

(what I found will be covered in a new PR)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930.

avatar ChristineWk ChristineWk - test_item - 19 Aug 2025 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 19 Aug 2025

I have tested this item ✅ successfully on d4f176a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930.

avatar ChristineWk
ChristineWk - comment - 19 Aug 2025

In case anyone is interested:
As mentioned above, when calling installed extensions, the following message appears:
Cannot access protected property Joomla\CMS\Application\AdministratorApplication::$input
It should be changed from:
Factory::getApplication()->input->get
to:
Factory::getApplication()->getInput->input->get
(This will probably be changed with J6 Alpha4).

avatar richard67
richard67 - comment - 23 Aug 2025

Cannot access protected property Joomla\CMS\Application\AdministratorApplication::$input

@ChristineWk This is a known issue we have observed with 3rd party extensions. Do you have some installed on your site? If yes, which?

avatar richard67
richard67 - comment - 23 Aug 2025

To all testers: Have you also checked that the metismenu is not broken?

avatar richard67 richard67 - change - 23 Aug 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 23 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45930.

avatar ChristineWk
ChristineWk - comment - 23 Aug 2025

The changes are for the standard Joomla menu.

It affected Phoca extensions, but it was version 6.0.0-alpha4-dev. I informed Jan about it and therefore copied his changed code (see above) here. It should work with a newer beta version.

avatar richard67
richard67 - comment - 23 Aug 2025

@ChristineWk I know that the changes made by this PR here are for the standard menu. But the standard menu and the metismenu might share some class names in the markup, so CSS might be applied on both.

Add a Comment

Login with GitHub to post a comment