[#45925] - [6.0] No htmlhelper for js
- Ready to Commit
- Medium
- Build: 6.0-dev
- # 45925
- Diff
- dgrammatiko:6.0-dev/no-htmlhelper-for-js
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- replace
HTMLHelper::_('behavior.xxx');with the WAM counterpart as it exists in all the function of HTMLHelper::behavior comments:
Testing Instructions
Code review
Actual result BEFORE applying this Pull Request
everything works
Expected result AFTER applying this Pull Request
Everything works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules com_templates Front End com_config Installation Layout Libraries |
| Labels |
Added:
PR-6.0-dev
|
||
@dgrammatiko Is this PR here still needed now after #45000 has been merged?
The installation parts were overlapping but there are few more that are still to get into wam
The installation parts were overlapping but there are few more that are still to get into wam
@dgrammatiko Yes, I've just noticed. Was trying to solve the conflicts. Will do that now.
| Category | Administration com_modules com_templates Front End com_config Installation Layout Libraries | ⇒ | Administration com_modules com_templates Front End com_config Layout Libraries |
I was faster but thanks
@dgrammatiko Unfortunately unit tests are failing: https://github.com/joomla/joomla-cms/actions/runs/17019272040/job/48246052442?pr=45925
I see Exception: Failed to start application but have no clue why?
I see
Exception: Failed to start applicationbut have no clue why?
Me neither. I've restarted jobs, maybe it was a temporary glitch. If it fails again it needs to check in a local development environment to build and make a new installation.
@richard67 tests fixed (by removing irrelevant deprecated call replacements)
@dgrammatiko Unfortunately 6.0.0-beta1 has already been prepared. But I am sure we will get this PR ready for 6.0.0-beta2.
That’s fine I didn’t expect it to be merged immediately
I have tested this item ✅ successfully on 8c9a17f
I have successfully tested this.
To be clear, I tested Administrator and Site Modules, Site and Administrator Templates settings, Custom Fields, Articles, - reading, changing etc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45925.
I have tested this item ✅ successfully on 8c9a17f
Tested on articles, modules, templates. Everything works as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45925.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45925.
| Labels |
Added:
RTC
PBF
bug
|
||
@dgrammatiko Please check in your changes on GitHub where PHPstan reports issues: https://github.com/joomla/joomla-cms/pull/45925/files and fix them. They are all
Call to deprecated method getDocument() of class Joomla\CMS\Factory. Thanks in advance.