[#4592] - [Code Style] com_menus backend
- Closed
- 24 Oct 2014
- Medium
- Build: staging
- # 4592
- Diff
- phproberto:cs-com_menus-backend
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
This includes all code styles fixes (except class comments because we will create an independent PR for that) for backend com_menus component
jissues-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
Can't merge locally the changes in:
com_menus/tables/menu.php
javigomez
- | Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Code style |
| Labels |
Added:
?
|
||
JM, make sure you're on the latest staging and hopefully it should work.
Yes, works now
I am afraid of committing this in the middle of the pbf as it could break many PRs
@infograf768 maybe leave it until tomorrow?
or later, yep
@phproberto Can you solve the conflicts here?
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Fixed conflicts, rebased and squashed.
Travis failure unrelated to the PR - code style broken from another just commited - so can still be merged
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4592.
zero-24
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-24 13:02:39 |
| Labels |
Removed:
?
|
||
I added the missing since tags and rebased it to fix some conflicts with latest staging