[#45890] - [5.4] Use database from container and fix menuType table instantiation
- Fixed in Code Base
- 13 Aug 2025
- Medium
- Build: 5.4-dev
- # 45890
- Diff
- richard67:5.4-dev-fix-admin-menu
User tests: Successful: Unsuccessful:
Pull Request for Issue #45886 .
Summary of Changes
This pull request (PR) fixes a regression which was introduced in 5.4.0-alpha3 and 6.0.0-alpha3 with PR #45687 .
Thanks to @HLeithner for suggestions on how to fix it.
Testing Instructions
Copied from issue #45886 :
- Enable debug (so that you will get the bug stack trace)
- In the admin create a new admin menu - no need to create any items
- Click on add module and publish the module in the menu position
- Click on any item in the menu
Actual result BEFORE applying this Pull Request
See issue #45886 .
Expected result AFTER applying this Pull Request
Menu item opens.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
seems to have the same problem
@brianteeman My mistake, use statement for the Factory is missing.
| Labels |
Added:
PR-5.4-dev
|
||
yes that works
| Title |
|
||||||
I have tested this item ✅ successfully on bcebe72
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45890.
| Labels |
Added:
Release Blocker
bug
|
||
@brianteeman Could you test again? That would be great. Thanks in advance.
I have tested this item ✅ successfully on fffe775
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45890.
I have tested this item ✅ successfully on fffe775
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45890.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45890.
✅ Final Test before merge
- Seen the 500 'Call to a member function load() on false'
- JBT graft full package, tested issue is fixed, tested all positions
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-08-13 04:16:11 |
| Closed_By | ⇒ | muhme | |
| Labels |
Added:
RTC
|
||
seems to have the same problem