[#45875] - [6.0] [Guided Tours] Remove What's New tours on update from Joomla 5
- Pending
- Medium
- Build: 6.0-dev
- # 45875
- Diff
- obuisard:gt-removetours
User tests: Successful: Unsuccessful:
Follow up of PR#45512.
Summary of Changes
On update from Joomla 5, the Joomla 6 instance should be cleaned of all What's New tours meant for Joomla 5.
If this is approved, the language files and images should not be excluded from deletion on update any longer (see #45850).
Testing Instructions
Update to Joomla 6 from Joomla 5.4.
Go to System -> Manage -> Guided Tours
Actual result BEFORE applying this Pull Request
What's New tours for Joomla 5.2, 5.3 and 5.4 should be present.
Expected result AFTER applying this Pull Request
What's New tours for Joomla 5.2, 5.3 and 5.4 should be removed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql |
I have tried testing this PR, and received an orange warning at the top of website after update:
JInstaller: :Install: Error SQL You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '"#guidedtour_steps" WHERE "tour_id" IN (SELECT "id" FROM "#guidedtours" ...' at line 1
YET, the What's New tours for Joomla 5.2, 5.3 and 5.4 are gone from the System --> Manage --> Guided Tours list ?!
(Checking the database, it looks like they are gone as well:
Due to the warning/error, I can't make it a successful test :/
@exlemor Have you read my review comment? It clearly tells that this PR is broken and leads to SQL errors when updating.
(now that you pointed it out yes lol - I had the page open which didn't include your comment when I was testing it, I guess I should have reloaded the page and then I would have noticed your comment before testing ;) ) (thanks)
| Labels |
Added:
PR-6.0-dev
Guided Tours
|
||
I have tested this item ✅ successfully on 76b094e
I was able to successfully test this after latest fixes - thanks @obuisard, @richard67 for the recommendations.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45875.
I have tested this item 🔴 unsuccessfully on 7b27377
Using PostgreSQL names quotes in scripts for MySQL and MariaDB causes SQL errors and the update breaks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45875.