RTC PBF bug RMDQ PR-6.0-dev Guided Tours Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
10 Aug 2025

Follow up of PR#45512.

Summary of Changes

On update from Joomla 5, the Joomla 6 instance should be cleaned of all What's New tours meant for Joomla 5.
If this is approved, the language files and images should not be excluded from deletion on update any longer (see #45850).

Testing Instructions

Update to Joomla 6 from Joomla 5.4.
Go to System -> Manage -> Guided Tours

Actual result BEFORE applying this Pull Request

What's New tours for Joomla 5.2, 5.3 and 5.4 should be present.

Expected result AFTER applying this Pull Request

What's New tours for Joomla 5.2, 5.3 and 5.4 should be removed.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar obuisard obuisard - open - 10 Aug 2025
avatar obuisard obuisard - change - 10 Aug 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2025
Category SQL Administration com_admin Postgresql
avatar obuisard obuisard - change - 10 Aug 2025
The description was changed
avatar obuisard obuisard - edited - 10 Aug 2025
avatar obuisard obuisard - change - 10 Aug 2025
The description was changed
avatar obuisard obuisard - edited - 10 Aug 2025
avatar obuisard obuisard - change - 10 Aug 2025
The description was changed
avatar obuisard obuisard - edited - 10 Aug 2025
avatar richard67 richard67 - test_item - 10 Aug 2025 - Tested unsuccessfully
avatar richard67
richard67 - comment - 10 Aug 2025

I have tested this item 🔴 unsuccessfully on 7b27377

Using PostgreSQL names quotes in scripts for MySQL and MariaDB causes SQL errors and the update breaks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45875.

avatar exlemor
exlemor - comment - 10 Aug 2025

I have tried testing this PR, and received an orange warning at the top of website after update:

JInstaller: :Install: Error SQL You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '"#guidedtour_steps" WHERE "tour_id" IN (SELECT "id" FROM "#guidedtours" ...' at line 1

YET, the What's New tours for Joomla 5.2, 5.3 and 5.4 are gone from the System --> Manage --> Guided Tours list ?!
(Checking the database, it looks like they are gone as well:

ScreenFloat Shot of Safari at Aug 10, 2025 at 5_18_56 PM

Due to the warning/error, I can't make it a successful test :/

avatar richard67
richard67 - comment - 10 Aug 2025

@exlemor Have you read my review comment? It clearly tells that this PR is broken and leads to SQL errors when updating.

avatar exlemor
exlemor - comment - 10 Aug 2025

@exlemor Have you read my review comment? It clearly tells that this PR is broken and leads to SQL errors when updating.

(now that you pointed it out yes lol - I had the page open which didn't include your comment when I was testing it, I guess I should have reloaded the page and then I would have noticed your comment before testing ;) ) (thanks)

avatar obuisard obuisard - change - 10 Aug 2025
Labels Added: PR-6.0-dev Guided Tours
avatar exlemor exlemor - test_item - 10 Aug 2025 - Tested successfully
avatar exlemor
exlemor - comment - 10 Aug 2025

I have tested this item ✅ successfully on 76b094e

I was able to successfully test this after latest fixes - thanks @obuisard, @richard67 for the recommendations.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45875.

avatar richard67 richard67 - change - 23 Aug 2025
Labels Added: PBF bug
avatar richard67
richard67 - comment - 23 Aug 2025

@obuisard I've allowed myself to rename the update SQL scripts so they are newer than the recently merged ones from other PRs and not collide with your other PR.

avatar richard67 richard67 - alter_testresult - 23 Aug 2025 - exlemor: Tested successfully
avatar richard67
richard67 - comment - 23 Aug 2025

@exlemor 's test is still valid because when he had tested, the other PRs with newer update SQL scripts were not merged yet, and so it worked. But now it would not work anymore, that's why I've renamed the scripts.

avatar richard67 richard67 - alter_testresult - 23 Aug 2025 - exlemor: Tested successfully
avatar rbuelund rbuelund - test_item - 23 Aug 2025 - Tested successfully
avatar rbuelund
rbuelund - comment - 23 Aug 2025

I have tested this item ✅ successfully on eb0f0ad


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45875.

avatar richard67 richard67 - alter_testresult - 10 Sep 2025 - 45875: Tested successfully
avatar richard67 richard67 - alter_testresult - 10 Sep 2025 - 45875: Not tested
avatar richard67 richard67 - alter_testresult - 10 Sep 2025 - 45875: Not tested
avatar richard67 richard67 - alter_testresult - 10 Sep 2025 - rbuelund: Tested successfully
avatar richard67 richard67 - alter_testresult - 10 Sep 2025 - rbuelund: Tested successfully
avatar paternax paternax - test_item - 10 Sep 2025 - Tested successfully
avatar paternax
paternax - comment - 10 Sep 2025

I have tested this item ✅ successfully on 56ffd8c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45875.

avatar richard67 richard67 - change - 10 Sep 2025
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 10 Sep 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45875.

avatar richard67
richard67 - comment - 10 Sep 2025

Maintainers will decide if they want this PR.

avatar softforge softforge - change - 16 Sep 2025
Labels Added: RTC RMDQ
avatar Bodge-IT Bodge-IT - change - 16 Sep 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-09-16 18:39:27
Closed_By Bodge-IT
avatar Bodge-IT Bodge-IT - close - 16 Sep 2025
avatar Bodge-IT Bodge-IT - merge - 16 Sep 2025
avatar Bodge-IT
Bodge-IT - comment - 16 Sep 2025

Decided! Big thanks to @obuisard for the work on the tour and to the testers @rbuelund and @paternax for tests

avatar richard67
richard67 - comment - 16 Sep 2025

@Bodge-IT @softforge The update SQL scripts "6.0.0-2025-08-21.sql" from this PR should have been renamed before merging because we already have scripts "6.0.0-2025-09-05.sql" which we have released with Beta 3 today, so if people will update to RC1 with this PR in, the scripts will not run. I have explained that to you both several times. I will make a PR later today or during this week as soon as I can find the time to fix that. But please keep it in mind for the future.

Add a Comment

Login with GitHub to post a comment