User tests: Successful: Unsuccessful:
Follow up of PR#45512.
On update from Joomla 5, the Joomla 6 instance should be cleaned of all What's New tours meant for Joomla 5.
If this is approved, the language files and images should not be excluded from deletion on update any longer (see #45850).
Update to Joomla 6 from Joomla 5.4.
Go to System -> Manage -> Guided Tours
What's New tours for Joomla 5.2, 5.3 and 5.4 should be present.
What's New tours for Joomla 5.2, 5.3 and 5.4 should be removed.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql |
I have tried testing this PR, and received an orange warning at the top of website after update:
JInstaller: :Install: Error SQL You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '"#guidedtour_steps" WHERE "tour_id" IN (SELECT "id" FROM "#guidedtours" ...' at line 1
YET, the What's New tours for Joomla 5.2, 5.3 and 5.4 are gone from the System --> Manage --> Guided Tours list ?!
(Checking the database, it looks like they are gone as well:
Due to the warning/error, I can't make it a successful test :/
@exlemor Have you read my review comment? It clearly tells that this PR is broken and leads to SQL errors when updating.
(now that you pointed it out yes lol - I had the page open which didn't include your comment when I was testing it, I guess I should have reloaded the page and then I would have noticed your comment before testing ;) ) (thanks)
Labels |
Added:
PR-6.0-dev
Guided Tours
|
I have tested this item ✅ successfully on 76b094e
I was able to successfully test this after latest fixes - thanks @obuisard, @richard67 for the recommendations.
Labels |
Added:
PBF
bug
|
I have tested this item ✅ successfully on eb0f0ad
I have tested this item ✅ successfully on 56ffd8c
Status | Pending | ⇒ | Ready to Commit |
RTC
Maintainers will decide if they want this PR.
Labels |
Added:
RTC
RMDQ
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-09-16 18:39:27 |
Closed_By | ⇒ | Bodge-IT |
@Bodge-IT @softforge The update SQL scripts "6.0.0-2025-08-21.sql" from this PR should have been renamed before merging because we already have scripts "6.0.0-2025-09-05.sql" which we have released with Beta 3 today, so if people will update to RC1 with this PR in, the scripts will not run. I have explained that to you both several times. I will make a PR later today or during this week as soon as I can find the time to fix that. But please keep it in mind for the future.
I have tested this item 🔴 unsuccessfully on 7b27377
Using PostgreSQL names quotes in scripts for MySQL and MariaDB causes SQL errors and the update breaks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45875.