@ceford and @exlemor I would be delighted if you would test this PR.

@ceford and @exlemor I would be delighted if you would test this PR.

Gladly... I'm on it.

I have tested this item ✅ successfully on b18c52a

I have tested this PR successfully and very happily. This will reduce my client calls by at least 1/2 (no joke) Thanks @tecpromotion!

I am not convinced this is the correct approach as it hides that there are updates available. Even if you cannot do an update I believe the user should be informed an update is available

I am not convinced this is the correct approach as it hides that there are updates available. Even if you cannot do an update I believe the user should be informed an update is available

Thanks for your comment @brianteeman
Should it just be displayed (not clickable) or should a message appear when clicked telling the user to contact a super user?

I am not convinced this is the correct approach as it hides that there are updates available. Even if you cannot do an update I believe the user should be informed an update is available

Thanks for your comment @brianteeman Should it just be displayed (not clickable) or should a message appear when clicked telling the user to contact a super user?

Just displayed would be acceptable to me
Being asked to contact a super user would be preferred - I'm sure we have something similar to that somewhere

Just displayed would be acceptable to me Being asked to contact a super user would be preferred - I'm sure we have something similar to that somewhere

Okay, we use this check in different situations and in even more different ways.
Perhaps we can use this to our advantage.

// Access check. if (!$this->getCurrentUser()->authorise('core.admin')) { throw new NotAllowed(Text::_('JERROR_ALERTNOAUTHOR'), 403); }

But would that display that an update is available?

Please dont misunderstand me. The current situation is not good and needs to be fixed - I just believe that we should be able to inform admins that a new version is available even if they dont have the access to perform an update

But would that display that an update is available?

Please dont misunderstand me. The current situation is not good and needs to be fixed - I just believe that we should be able to inform admins that a new version is available even if they dont have the access to perform an update

What you would need to do in the onGetIcons function:

• In the early termination condition, only check the context.
• Then determine separately whether the user has core.admin on com_installer.
• Always build the icon, but adjust the link/class/title if the permission is missing.

sounds right to me

I have tested this item 🔴 unsuccessfully on 4b326d0

I applied the patch as Super User, went to the Home Dashboard and got this:

An error has occurred.
     0 Joomla\Plugin\Quickicon\Joomlaupdate\Extension\Joomlaupdate::__construct(): Argument #2 ($document) must be of type Joomla\CMS\Document\Document, array given, called in /Users/ceford/Sites/joomla-cms5/plugins/quickicon/joomlaupdate/services/provider.php on line 35 
Return to Dashboard
```<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/45872">issues.joomla.org/tracker/joomla-cms/45872</a>.</sub>