[#45870] - [7.0] Remove Factory::getConfig() and replace all usages
- Pending
- Medium
- Build: 6.0-dev
- # 45870
- Diff
- Hackwar:6.0-deprecations-config
User tests: Successful: Unsuccessful:
Summary of Changes
Factory::getConfig() has been deprecated for a long time. This PR removes it and also all usages in our core code.
Testing Instructions
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Libraries |
| Labels |
Added:
PR-6.0-dev
|
||
Yes, I am aware. It requires a bigger change of the tests. However the goal of this (and the other PRs) is to show what all needs to be done to finally solve all this stuff. All of these PRs also need documentation still.
Yes, I am aware. It requires a bigger change of the tests. However the goal of this (and the other PRs) is to show what all needs to be done to finally solve all this stuff. All of these PRs also need documentation still.
Maybe these PRs should then be set to draft mode so people won't waste time with testing as long as the PRs are not ready (which includes documentation and system tests passing)?
I have tested this item 🔴 unsuccessfully on dc35697
The file does not contain the new methods introduced by the PR (getVariables, setVariables, etc.). It only contains standard methods like parseSefRoute, buildSefRoute, etc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45870.
I have tested this item 🔴 unsuccessfully on dc35697
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45870.
| Labels |
Added:
bug
|
||
| Title |
|
||||||
| Category | Installation Libraries | ⇒ | Repository NPM Change JavaScript Front End com_banners Installation Language & Strings |
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
@Hackwar @wilsonge You are aware of the system tests failing? Seems it needs to change some Exceptions.