[#45869] - [6.1] Remove Factory::getSession() and replace all usages
- Ready to Commit
- Medium
- Build: 6.0-dev
- # 45869
- Diff
- Hackwar:6.0-deprecations-session
User tests: Successful: Unsuccessful:
Summary of Changes
Factory::getSession() has been deprecated for a long time. This PR removes it and also all usages in our core code.
Testing Instructions
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder com_joomlaupdate com_postinstall Front End com_contact Installation Libraries Plugins |
| Labels |
Added:
PR-6.0-dev
|
||
| Labels |
Added:
bug
|
||
I have tested this item ✅ successfully on bcb2dd6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45869.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45869.
Can we replace the usages in our core code for now and remove the method in the next major release? The method is still use in our core code until now, so it is very likely it is also used by third party extensions and these extensions will be broken in the upcoming 6.0 release.
| Labels |
Added:
RTC
|
||
I moved it to the b/c plugin, I didn't restored Factory::$session since it has not been initialized, so it's pretty useless anyway.
| Title |
|
||||||
I have tested this item ✅ successfully on bcb2dd6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45869.