[#45860] - [7.0] Remove static methods from frontend modules
- Pending
- Medium
- Build: 6.0-dev
- # 45860
- Diff
- Hackwar:6.0-deprecations-modules
User tests: Successful: Unsuccessful:
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
This PR removes static methods from the helpers of the frontend modules. The rest is removed in #47460.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org: joomla/Manual#608
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Labels |
Added:
PR-6.0-dev
|
||
I have tested this item ✅ successfully on 2b27aee
Code review: I see no calls to ::getList() in J6 and I see that some of these items will be removed in 6 and others in 7. Looks OK in my limited experience!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.
I have tested this item 🔴 unsuccessfully on 2b27aee
Getting this error on locally while applying the patch
The file marked for modification does not exist: phpstan-baseline.neon
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.
@vishalchincholi1 if you try to test this PR via Joomla Patch Tester even with the latest Nightly Build, you will get the error: The file marked for modification does not exist: phpstan-baseline.neon Use the Download package instead :)
I have removed the unsuccessful test from @vishalchincholi1 as they had not tested the pr
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.
| Status | Ready to Commit | ⇒ | Pending |
Back to draft
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.
| Title |
|
||||||
![avatar github-actions[bot]](/images/avatars/github-actions[bot].png)
This pull request has conflicts, please resolve those before we can evaluate the pull request.
| Labels |
Added:
Conflicting Files
PR-7.0-dev
|
||
| Labels |
Removed:
Conflicting Files
|
||
| Labels |
Added:
Feature
Removed: PR-6.0-dev |
||
I have tested this item ✅ successfully on 2b27aee
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45860.