RTC PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar joomlaweby
joomlaweby
4 Aug 2025

Summary of Changes

Converts the site login module to service provider.

Testing Instructions

  1. Make sure you have site module mod_login published
  2. You should see module output
  3. Try also to be logged-in/out
mod_login_site

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomlaweby joomlaweby - open - 4 Aug 2025
avatar joomlaweby joomlaweby - change - 4 Aug 2025
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Aug 2025
Category Modules Front End
avatar exlemor exlemor - test_item - 4 Aug 2025 - Tested successfully
avatar exlemor
exlemor - comment - 4 Aug 2025

I have tested this item ✅ successfully on a9d3b12

I have successfully tested this - nice work @joomlaweby - I don't know how many more of these need converting to service provider, but keep 'em coming ;) I'll gladly test them ALL :) Cheers.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45835.

avatar RickR2H RickR2H - test_item - 5 Aug 2025 - Tested successfully
avatar RickR2H
RickR2H - comment - 5 Aug 2025

I have tested this item ✅ successfully on a9d3b12


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45835.

avatar RickR2H RickR2H - change - 5 Aug 2025
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 5 Aug 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45835.

avatar joomlaweby
joomlaweby - comment - 5 Aug 2025

I have tested this item ✅ successfully on a9d3b12I have successfully tested this - nice work @joomlaweby - I don't know how many more of these need converting to service provider, but keep 'em coming ;) I'll gladly test them ALL :) Cheers.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45835.

I think there are 2 more modules...I've got them prepared :-)

avatar muhme muhme - change - 5 Aug 2025
Labels Added: RTC
avatar richard67
richard67 - comment - 5 Aug 2025

I think there are 2 more modules...I've got them prepared :-)

@joomlaweby Would be good to get them ready and tested before the end of next week when we will build our packages for Beta 1.

avatar joomlaweby joomlaweby - change - 5 Aug 2025
Labels Added: PR-5.4-dev
avatar richard67
richard67 - comment - 5 Aug 2025

RTC is still valid, commits after that were just clean branch updates and code style (removal of empty line).

avatar muhme
muhme - comment - 6 Aug 2025

✅ Final test before merge, with JBT graft Joomla_5.4.0-alpha4-dev+pr.45835-Development-Full_Package.zip

  • Tested with Firefox, Safari, Chrome and Edge
  • Created user with only Editor rights, logged in with admin and editor
  • Tested forgot your password and forgot your user name
  • Tested with and without remember me after browser restart
  • Tested disabling title, pre- and post-text
  • Installed German language paket and switch to German as default language, checked login form in German
  • Checked logs/error.php for logged login failures
  • Enabled user registration, checked link is working
avatar muhme muhme - change - 6 Aug 2025
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2025-08-06 04:46:58
Closed_By muhme
avatar muhme muhme - close - 6 Aug 2025
avatar muhme muhme - merge - 6 Aug 2025
avatar muhme
muhme - comment - 6 Aug 2025

Thank you @joomlaweby for your contribution. Thank you @exlemor and @RickR2H for testing.

Add a Comment

Login with GitHub to post a comment